Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing log with tracing #75090

Closed

Conversation

gdhuper
Copy link
Contributor

@gdhuper gdhuper commented Aug 3, 2020

Description

Replaced log with tracing in the following crates:

  • librustc_ast
  • librustc_driver
  • librustc_errors
  • librustc_expand
  • librustc_hir
  • librustc_incremental
  • librustc_infer
  • librustc_interface
  • librustc_lint
  • librustc_metadata
  • librustc_middle
  • librustc_mir
  • librustc_mir_build
  • librustc_parse
  • librustc_passes
  • librustc_privacy
  • librustc_query_system
  • librustc_resolve
  • librustc_save_analysis
  • librustc_session
  • librustc_span
  • librustc_symbol_mangling
  • librustc_target
  • librustc_trait_selection
  • librustc_traits
  • librustc_ty
  • librustc_typeck
  • compiletest

Fixes: #74747

Checklist:

  • Code compiles / builds
  • run tidy
  • Cleanup any clippy warnings
  • Update/add docs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
@bors
Copy link
Contributor

bors commented Aug 8, 2020

☔ The latest upstream changes (presumably #75276) made this pull request unmergeable. Please resolve the merge conflicts.

@gdhuper
Copy link
Contributor Author

gdhuper commented Aug 12, 2020

Can someone help me with why the build is failing? I ran tiddy locally before pushing but it's still failing tiddy check. Appreciate any help.

EDIT: Found the issue. It was the conflict in formatting (rustfmt vs tidy).

@bors
Copy link
Contributor

bors commented Aug 13, 2020

☔ The latest upstream changes (presumably #75426) made this pull request unmergeable. Please resolve the merge conflicts.

@gdhuper gdhuper closed this Aug 14, 2020
@gdhuper gdhuper deleted the gdhuper/renaming_log_to_tracing branch August 14, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove log renamings of tracing crate
4 participants