Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log alias from librustdoc #75139

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Remove log alias from librustdoc #75139

merged 1 commit into from
Aug 5, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Aug 4, 2020 •
edited
Loading

r? @jyn514

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Aug 4, 2020

r? @jyn514

@GuillaumeGomez
Copy link
Member

Could you please add the link to the PR who made this change originally please? (Maybe @jyn514 has it?)

r=me once CI pass

@pickfire
Copy link
Contributor Author

pickfire commented Aug 4, 2020 •
edited
Loading

#75081

tl;dr @jyn514 change

-extern crate log;
+extern crate tracing as log;

@jyn514
Copy link
Member

jyn514 commented Aug 4, 2020

Whoops, I didn't realize it wasn't used anywhere else 😆

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit c577d71 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 4, 2020

Thanks for working on this!

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit c577d71 with merge 8f45f611a73a6d5eeb172afcdfc1da472f660a86...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@jyn514
Copy link
Member

jyn514 commented Aug 4, 2020

@bors retry

network failure:

2020-08-04T13:27:21.0741126Z Cloning into '/mnt/more-space/workspace/src/tools/cargo'...
2020-08-04T13:27:21.1907227Z fatal: unable to access 'https://github.com/rust-lang/cargo.git/': transfer closed with outstanding read data remaining
2020-08-04T13:27:21.1932606Z fatal: clone of 'https://github.com/rust-lang/cargo.git' into submodule path '/mnt/more-space/workspace/src/tools/cargo' failed
2020-08-04T13:27:21.1933673Z Failed to clone 'src/tools/cargo'. Retry scheduled
2020-08-04T13:27:21.3200771Z Cloning into '/mnt/more-space/workspace/src/tools/cargo'...
2020-08-04T13:27:21.3202045Z fatal: unable to access 'https://github.com/rust-lang/cargo.git/': transfer closed with outstanding read data remaining
2020-08-04T13:27:21.3203140Z fatal: clone of 'https://github.com/rust-lang/cargo.git' into submodule path '/mnt/more-space/workspace/src/tools/cargo' failed
2020-08-04T13:27:21.3203625Z Failed to clone 'src/tools/cargo' a second time, aborting
2020-08-04T13:27:21.3218123Z + [[ 5 -lt 5 ]]
2020-08-04T13:27:21.3218590Z The command has failed after 5 attempts.
2020-08-04T13:27:21.3219126Z + echo 'The command has failed after 5 attempts.'

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit c577d71 with merge e8f7a136cc0a00495becdaf25b9b5d5daae42b6e...

@pickfire
Copy link
Contributor Author

pickfire commented Aug 4, 2020 •
edited
Loading

@jyn514 Well, this is simpler than the one you mentioned. I was surprised it wasn't using 2018 edition features to not have #[macro_use] but I guess I was mistaken.

@bors
Copy link
Contributor

bors commented Aug 4, 2020

💔 Test failed - checks-azure

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 4, 2020
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@mati865
Copy link
Contributor

mati865 commented Aug 4, 2020

MacOS bug?
Assertion failed: (timeout != -1), function uv__io_poll, file ../deps/uv/src/unix/kqueue.c, line 231.

@JohnTitor
Copy link
Member

Hm yeah, and seems spurious, let's retry.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 5, 2020
@Manishearth
Rollup merge of rust-lang#75139 - pickfire:librustdoc-import, r=jyn514
82b4f87 
Remove log alias from librustdoc

r? @jyn514
@Manishearth Manishearth mentioned this pull request Aug 5, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Aug 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2020
@bors
Auto merge of rust-lang#75174 - JohnTitor:rollup-z9djftk, r=JohnTitor
119d2a1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#75139 (Remove log alias from librustdoc)
 - rust-lang#75140 (Clean up E0745)
 - rust-lang#75149 (Correct a typo in interpret/memory.rs)
 - rust-lang#75152 (Replace `Memoryblock` with `NonNull<[u8]>`)
 - rust-lang#75168 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit 7b39f75 into rust-lang:master Aug 5, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
9 participants
@pickfire @rust-highfive @GuillaumeGomez @jyn514 @bors @rust-log-analyzer @mati865 @JohnTitor @cuviper