Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporated Tracing Crate in some libraries #75187

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

pawanbisht62
Copy link
Contributor

Issue #74747

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@bors
Copy link
Contributor

bors commented Aug 9, 2020

☔ The latest upstream changes (presumably #75278) made this pull request unmergeable. Please resolve the merge conflicts.

@pawanbisht62
Copy link
Contributor Author

@bors I've resolved the conflicts. Thanks

@bishtpawan
Copy link
Contributor

@estebank can you please have a look at the PR as this is assigned to you. Thanks

@bors
Copy link
Contributor

bors commented Aug 15, 2020

☔ The latest upstream changes (presumably #73851) made this pull request unmergeable. Please resolve the merge conflicts.

@pawanbisht62
Copy link
Contributor Author

@bors I've resolved the conflicts please have a look once you get time. Thanks

@bishtpawan
Copy link
Contributor

@oli-obk can you please have a look at this issue? As this PR is related to #74747.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 17, 2020

@bors r+

apologies, I did not see this PR. Looks good to me, thanks!

@bors
Copy link
Contributor

bors commented Aug 17, 2020

📌 Commit bab1588 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2020
@bors
Copy link
Contributor

bors commented Aug 17, 2020

⌛ Testing commit bab1588 with merge 8d185ca...

@bors
Copy link
Contributor

bors commented Aug 17, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 8d185ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2020
@bors bors merged commit 8d185ca into rust-lang:master Aug 17, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants