-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporated Tracing Crate in some libraries #75187
Incorporated Tracing Crate in some libraries #75187
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
3c3c0f8
to
fdfbd89
Compare
☔ The latest upstream changes (presumably #75278) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors I've resolved the conflicts. Thanks |
@estebank can you please have a look at the PR as this is assigned to you. Thanks |
☔ The latest upstream changes (presumably #73851) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors I've resolved the conflicts please have a look once you get time. Thanks |
@bors r+ apologies, I did not see this PR. Looks good to me, thanks! |
📌 Commit bab1588 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Issue #74747