Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 2867] Instruction set #75202

Closed
wants to merge 4 commits into from
Closed

[RFC 2867] Instruction set #75202

wants to merge 4 commits into from

Conversation

Lokathor
Copy link
Contributor

@Lokathor Lokathor commented Aug 5, 2020 •
edited
Loading

  • feature gate.
  • attribute.
  • attribute rejects bad inputs.
  • attribute modifiers function metadata.
  • function metadata affects codegen.

Tracker

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@Lokathor
Copy link
Contributor Author

Lokathor commented Aug 5, 2020

I don't seem to understand how declare_features! works. It looks like it should be making the field it's using automatically, so I don't understand the "missing field" error.

@bors
Copy link
Contributor

bors commented Aug 8, 2020

☔ The latest upstream changes (presumably #74877) made this pull request unmergeable. Please resolve the merge conflicts.

@Lokathor Lokathor closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lokathor @rust-highfive @bors @varkor