Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rustc_lexer::is_ident and use it in couple of places #75378

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Aug 10, 2020

Implements the suggestion from #74537 (comment).

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2020

📌 Commit 6bbf455 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2020
@bors
Copy link
Contributor

bors commented Aug 11, 2020

⌛ Testing commit 6bbf455 with merge 6bb16ab9e08f25b174aa30cdb8a7878fc8c5bfff...

@tmandry
Copy link
Member

tmandry commented Aug 11, 2020

@bors retry rolled up

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#75036 (Prefer pattern matching over indexing)
 - rust-lang#75378 (Introduce `rustc_lexer::is_ident` and use it in couple of places)
 - rust-lang#75393 (Fully handle "?" shortcut)
 - rust-lang#75403 (Update comment for function)
 - rust-lang#75407 (Requested changes to [*mut T|*const T]::set_ptr_value)
 - rust-lang#75408 (Update MinGW comments in ci.yml)
 - rust-lang#75409 (Fix range term in alloc vec doc)

Failed merges:

r? @ghost
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
##[group]Run exit 1
exit 1
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[error]Process completed with exit code 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors bors merged commit c18b64c into rust-lang:master Aug 11, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants