Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced log with tracing #75514

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Replaced log with tracing #75514

merged 1 commit into from
Aug 15, 2020

Conversation

gdhuper
Copy link
Contributor

@gdhuper gdhuper commented Aug 14, 2020 •
edited
Loading

Description

Replaced log with tracing in the following crates:

  • librustc_ast
  • librustc_driver
  • librustc_errors
  • librustc_expand
  • librustc_hir
  • librustc_incremental
  • librustc_infer
  • librustc_interface
  • librustc_lint
  • librustc_metadata
  • librustc_middle
  • librustc_mir
  • librustc_mir_build
  • librustc_parse
  • librustc_passes
  • librustc_privacy
  • librustc_query_system
  • librustc_resolve
  • librustc_save_analysis
  • librustc_session
  • librustc_span
  • librustc_symbol_mangling
  • librustc_target
  • librustc_trait_selection
  • librustc_traits
  • librustc_ty
  • librustc_typeck
  • compiletest

Fixes: #74747

Checklist:

  • Code compiles / builds
  • run tidy
  • Cleanup any clippy warnings
  • Update/add docs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
@gdhuper gdhuper marked this pull request as ready for review August 14, 2020 06:41
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2020

📌 Commit c5ba2128d854032f843e9532ffa663ab4dc41fd8 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2020
@tmandry tmandry mentioned this pull request Aug 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 15, 2020
@bors
Auto merge of rust-lang#75549 - tmandry:rollup-sxjwa0w, r=tmandry
45060c2 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#75376 (Set CMAKE_SYSTEM_NAME when cross-compiling)
 - rust-lang#75448 (merge `as_local_hir_id` with `local_def_id_to_hir_id`)
 - rust-lang#75513 (Recover gracefully from `struct` parse errors)
 - rust-lang#75545 (std/sys/unix/time: make it easier for LLVM to optimize `Instant` subtraction.)

Failed merges:

 - rust-lang#75514 (Replaced `log` with `tracing`)

r? @ghost
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2020
@crlf0710
Copy link
Member

@gdhuper A rebase is needed since we're don't accept PRs with merge commits in them.

@gdhuper
Copy link
Contributor Author

gdhuper commented Aug 15, 2020

@gdhuper A rebase is needed since we're don't accept PRs with merge commits in them.

@crlf0710 Thanks for the heads up. I didn't know this. Should I cherry pick previous commit and then rebase or recreate a branch?

@mati865
Copy link
Contributor

mati865 commented Aug 15, 2020

@gdhuper in your case git rebase <rust-lang-name>/master (replace rust-lang-name with the name you have configured for https://github.com/rust-lang/rust.git) and that should remove merge commit.

@gdhuper gdhuper force-pushed the gdhuper/replace_log_with_tracing branch from ea15c3f to d2753f9 Compare August 15, 2020 20:05
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 15, 2020

📌 Commit d2753f9 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2020
@bors
Copy link
Contributor

bors commented Aug 15, 2020

⌛ Testing commit d2753f9 with merge 9b88e0a...

@bors
Copy link
Contributor

bors commented Aug 15, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 9b88e0a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2020
@bors bors merged commit 9b88e0a into rust-lang:master Aug 15, 2020
@bors bors mentioned this pull request Aug 16, 2020
Merged
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Remove log renamings of tracing crate
7 participants
@gdhuper @rust-highfive @davidtwco @bors @crlf0710 @mati865 @cuviper