Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied #![deny(unsafe_op_in_unsafe_fn)] in library/std/src/wasi #75971

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Amjad50
Copy link
Contributor

@Amjad50 Amjad50 commented Aug 27, 2020

partial fix for #73904

There are still more that was not applied in mod.rs and that is due to its using files from ../unsupported

like:

#[path = "../unsupported/cmath.rs"]
pub mod cmath;

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2020
@Amjad50
Copy link
Contributor Author

Amjad50 commented Aug 28, 2020

r? @Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2020
@Amjad50
Copy link
Contributor Author

Amjad50 commented Sep 1, 2020

@Mark-Simulacrum ?

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed and commits squashed

library/std/src/sys/wasi/alloc.rs Outdated Show resolved Hide resolved
library/std/src/sys/wasi/alloc.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed, likely into one

@Amjad50
Copy link
Contributor Author

Amjad50 commented Sep 2, 2020

should I force push them into one?

@Mark-Simulacrum
Copy link
Member

Yep!

All refactoring needed was only in `alloc.rs`, changed part of the code
in `alloc` method to satisfy the SAFETY statement
@Amjad50 Amjad50 force-pushed the libstd-deny-unsafe_op_in_unsafe_fn branch from b8d86e2 to 559679b Compare September 3, 2020 00:29
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 3, 2020

📌 Commit 559679b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2020
@bors
Copy link
Contributor

bors commented Sep 3, 2020

⌛ Testing commit 559679b with merge 1e33c74...

@bors
Copy link
Contributor

bors commented Sep 3, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 1e33c74 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2020
@bors bors merged commit 1e33c74 into rust-lang:master Sep 3, 2020
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants