Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove headers from exchange allocations #7605

Merged
merged 3 commits into from
Jul 8, 2013
Merged

remove headers from exchange allocations #7605

merged 3 commits into from
Jul 8, 2013

Conversation

thestinger
Copy link
Contributor

This is work continued from the now landed #7495 and #7521 pulls.

Removing the headers from unique vectors is another project, so I've separated the allocator.

@graydon
Copy link
Contributor

graydon commented Jul 7, 2013

Cool. So um, concerning "what to do with this PR": if it doesn't bootstrap yet, you don't intend for anyone to merge it yet, right?

@thestinger
Copy link
Contributor Author

@graydon: yeah, it's currently hitting a double free in stage2

@thestinger
Copy link
Contributor Author

Down to these failures now:

    [run-pass] run-pass/borrowck-mut-uniq.rs
    [run-pass] run-pass/owned-trait-objects.rs
    [run-pass] run-pass/repeated-vector-syntax.rs
    [run-pass] run-pass/trait-bounds-in-arc.rs
    [run-pass] run-pass/unique-object.rs

@luqmana
Copy link
Member

luqmana commented Jul 7, 2013

So it seems like there is still at least 1 2 issue which is causing these tests to fail.

borrowck-mut-uniq and repeated-vector-syntax seem to be failing because of something to do with repr/reflect/visitor while owned-trait-objects, trait-bounds-in-arc and unique-object have to do with unique trait objects.

@thestinger
Copy link
Contributor Author

Down to 2 failures now thanks to @luqmana :)

    [run-pass] run-pass/borrowck-mut-uniq.rs
    [run-pass] run-pass/repeated-vector-syntax.rs

@thestinger
Copy link
Contributor Author

It now gets through run-pass and the libstd tests but hits memory corruption in the libextra json tests.

bors added a commit that referenced this pull request Jul 8, 2013
This is work continued from the now landed #7495 and #7521 pulls.

Removing the headers from unique vectors is another project, so I've separated the allocator.
@bors bors closed this Jul 8, 2013
@bors bors merged commit 90f1db1 into rust-lang:master Jul 8, 2013
@thestinger thestinger deleted the vec branch July 8, 2013 16:49
bors added a commit that referenced this pull request Jul 16, 2013
Note that the headers are still on `~[T]` when `T` is managed. This is continued from #7605, which removed all the code relying on the headers and removed them from `~T` for non-managed `T`.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 3, 2021
Issue 7548 fix

Close rust-lang#7548

changelog: [`bool_assert_comparison`] fixes should be emitted only in case they are comparing a value of a type that implements the `Not` trait with an output of type `bool` against a boolean literal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants