-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove headers from exchange allocations #7605
Conversation
Cool. So um, concerning "what to do with this PR": if it doesn't bootstrap yet, you don't intend for anyone to merge it yet, right? |
@graydon: yeah, it's currently hitting a double free in stage2 |
Down to these failures now:
|
So it seems like there is still at least 1
|
Down to 2 failures now thanks to @luqmana :)
|
It now gets through run-pass and the libstd tests but hits memory corruption in the libextra json tests. |
Note that the headers are still on `~[T]` when `T` is managed. This is continued from #7605, which removed all the code relying on the headers and removed them from `~T` for non-managed `T`.
Issue 7548 fix Close rust-lang#7548 changelog: [`bool_assert_comparison`] fixes should be emitted only in case they are comparing a value of a type that implements the `Not` trait with an output of type `bool` against a boolean literal.
This is work continued from the now landed #7495 and #7521 pulls.
Removing the headers from unique vectors is another project, so I've separated the allocator.