Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about ! and impl Trait #76099

Merged
merged 13 commits into from
Sep 2, 2020
Merged

Add info about ! and impl Trait #76099

merged 13 commits into from
Sep 2, 2020

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    4aae781 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd985e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d9a2ab View commit details
    Browse the repository at this point in the history
  4. Specify 0 of type u32

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    26eab6a View commit details
    Browse the repository at this point in the history
  5. Be more specific about polymorphic return types

    I no longer say "polymorphic" since it's a bit ambiguous here.
    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    80dcad9 View commit details
    Browse the repository at this point in the history
  6. other branch -> else branch

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    bd31962 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7e2548f View commit details
    Browse the repository at this point in the history
  8. Explain why the 0 is a u32

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    37ea97c View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Redefine Debug instead of importing it

    This reverts commit 7e2548f.
    
    Now I know why it was redefined: it seems like it's potentially because
    of the orphan rule. Here are the error messages:
    
    error[E0119]: conflicting implementations of trait `std::fmt::Debug` for type `!`:
     --> src/primitive_docs.rs:236:1
      |
    6 | impl Debug for ! {
      | ^^^^^^^^^^^^^^^^
      |
      = note: conflicting implementation in crate `core`:
              - impl std::fmt::Debug for !;
    
    error[E0117]: only traits defined in the current crate can be implemented for arbitrary types
     --> src/primitive_docs.rs:236:1
      |
    6 | impl Debug for ! {
      | ^^^^^^^^^^^^^^^-
      | |              |
      | |              `!` is not defined in the current crate
      | impl doesn't use only types from inside the current crate
      |
      = note: define and implement a trait or new type instead
    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e13a701 View commit details
    Browse the repository at this point in the history
  2. Remove empty comment

    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    cdd6f11 View commit details
    Browse the repository at this point in the history
  3. Improve wording

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    camelid and Joshua Nelson committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c4c058c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    913354b View commit details
    Browse the repository at this point in the history
  5. Break line at 100 characters

    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    55637f5 View commit details
    Browse the repository at this point in the history