Remove some of the @ from the AST
#7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍 |
|
This won't pass the tests as-is, since it unsuprisingly broke rustdoc (and it'll probably fail some other tests that I haven't run yet) I just wanted to get it up for feedback. |
|
Wonderful. r=me with p=100 on anything that has this form, assuming it doesn't introduce lots of new deep-copy-making. Especially keen on seeing the |
|
|
|
@cmr, not the change I was hoping for, but oh well. The extra time at the end is odd, but I'm going to cop out and blame noise. |
Also, makes the pretty-printer use & instead of @ as much as possible, which will help with later changes, though in the interim has produced some... interesting constructs.
bors
added a commit
that referenced
this pull request
Jul 7, 2013
In an ideal world, the AST would be completely sendable, this gets us a step closer. It removes the local heap allocations for `view_item`, `Path`, `Lifetime` `trait_ref` `OptVec<TyParamBounds>` and `Ty`. There are also a few other smaller changes I made as things went along.
|
Apparently, this adds 300 MB to the memory usage, but I guess it's a case of gets-worse-before-it-gets-better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an ideal world, the AST would be completely sendable, this gets us a step closer.
It removes the local heap allocations for
view_item,Path,Lifetimetrait_refOptVec<TyParamBounds>andTy. There are also a few other smaller changes I made as things went along.