Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #76231

Merged
merged 46 commits into from
Sep 2, 2020
Merged

Rollup of 14 pull requests #76231

merged 46 commits into from
Sep 2, 2020

Commits on Jul 28, 2020

  1. Configuration menu
    Copy the full SHA
    f3d7645 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Add more examples to lexicographic cmp on Iterators.

    The most important rule of lexicographical comparison is that two arrays
    of equal length will be compared until the first difference occured.
    
    The examples provided only focuses on the second rule that says that the
    shorter array will be filled with some T2 that is less than every T.
    Which is only possible because of the first rule.
    hbina committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    cc3b2f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    4aae781 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd985e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d9a2ab View commit details
    Browse the repository at this point in the history
  4. Specify 0 of type u32

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    26eab6a View commit details
    Browse the repository at this point in the history
  5. Be more specific about polymorphic return types

    I no longer say "polymorphic" since it's a bit ambiguous here.
    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    80dcad9 View commit details
    Browse the repository at this point in the history
  6. other branch -> else branch

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    bd31962 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7e2548f View commit details
    Browse the repository at this point in the history
  8. Explain why the 0 is a u32

    camelid committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    37ea97c View commit details
    Browse the repository at this point in the history
  9. Factor out StmtKind::MacCall fields into MacCallStmt struct

    In PR rust-lang#76130, I add a fourth field, which makes using a tuple variant
    somewhat unwieldy.
    Aaron1011 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    090b167 View commit details
    Browse the repository at this point in the history
  10. Fix clippy

    Aaron1011 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    ee19021 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    23f0ccf View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Redefine Debug instead of importing it

    This reverts commit 7e2548f.
    
    Now I know why it was redefined: it seems like it's potentially because
    of the orphan rule. Here are the error messages:
    
    error[E0119]: conflicting implementations of trait `std::fmt::Debug` for type `!`:
     --> src/primitive_docs.rs:236:1
      |
    6 | impl Debug for ! {
      | ^^^^^^^^^^^^^^^^
      |
      = note: conflicting implementation in crate `core`:
              - impl std::fmt::Debug for !;
    
    error[E0117]: only traits defined in the current crate can be implemented for arbitrary types
     --> src/primitive_docs.rs:236:1
      |
    6 | impl Debug for ! {
      | ^^^^^^^^^^^^^^^-
      | |              |
      | |              `!` is not defined in the current crate
      | impl doesn't use only types from inside the current crate
      |
      = note: define and implement a trait or new type instead
    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e13a701 View commit details
    Browse the repository at this point in the history
  2. Remove empty comment

    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    cdd6f11 View commit details
    Browse the repository at this point in the history
  3. Improve wording

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    camelid and Joshua Nelson committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c4c058c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    913354b View commit details
    Browse the repository at this point in the history
  5. Break line at 100 characters

    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    55637f5 View commit details
    Browse the repository at this point in the history
  6. Add new -Z dump-mir-spanview option

    Similar to `-Z dump-mir-graphviz`, this adds the option to write
    HTML+CSS files that allow users to analyze the spans associated with MIR
    elements (by individual statement, just terminator, or overall basic
    block).
    
    This PR was split out from PR rust-lang#76004, and exposes an API for spanview
    HTML+CSS files that is also used to analyze code regions chosen for
    coverage instrumentation (in a follow-on PR).
    
    Rust compiler MCP rust-lang/compiler-team#278
    
    Relevant issue: rust-lang#34701 - Implement support for LLVMs code coverage
    instrumentation
    richkadel committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    6b5869a View commit details
    Browse the repository at this point in the history
  7. Give a better error message for duplicate built-in macros

    Previously, this would say no such macro existed, but this was
    misleading, since the macro _did_ exist, it was just already seen.
    
    - Say where the macro was previously defined
    - Add long-form error message
    jyn514 committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    be2947d View commit details
    Browse the repository at this point in the history
  8. Use intra-doc links

    denisvasilik committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    9c7fb6c View commit details
    Browse the repository at this point in the history
  9. Enhance wording

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    denisvasilik and Joshua Nelson committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b639cb1 View commit details
    Browse the repository at this point in the history
  10. Make all methods of std::net::Ipv6Addr const

    Make the following methods of `std::net::Ipv6Addr` unstable const under the `const_ipv6` feature:
    - `segments`
    - `is_unspecified`
    - `is_loopback`
    - `is_global` (unstable)
    - `is_unique_local`
    - `is_unicast_link_local_strict`
    - `is_documentation`
    - `multicast_scope`
    - `is_multicast`
    - `to_ipv4_mapped`
    - `to_ipv4`
    
    Changed the implementation of `is_unspecified` and `is_loopback` to use a `match` instead of `==`.
    
    Part of rust-lang#76205
    CDirkx committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b31cc8f View commit details
    Browse the repository at this point in the history
  11. Use intra-doc links

    denisvasilik committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e7d0743 View commit details
    Browse the repository at this point in the history
  12. Improve readability

    denisvasilik committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    3510c56 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7eb4b1b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cd08def View commit details
    Browse the repository at this point in the history
  15. Change implementation of Ipv6Addr::is_unspecified and is_loopback

    … from `matches!` to `u128` comparison
    
    Done because `matches!` doesn't optimize well with array comparisons
    CDirkx committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a43dd4f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9afe97c View commit details
    Browse the repository at this point in the history
  17. Use "Fira Sans" for crate list font

    Fira Sans is what's used for module lists and other item lists.
    Previously, the default body font, "Source Serif Pro", was used for
    crate lists, which didn't visually match other item lists.
    camelid committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c86d249 View commit details
    Browse the repository at this point in the history
  18. lexer: Tiny improvement to shebang detection

    Lexer now discerns between regular comments and doc comments, so use that.
    The change only affects the choice of reported errors.
    petrochenkov committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b1491ea View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e5c17bf View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Rollup merge of rust-lang#74880 - chrisduerr:fix_matches, r=dtolnay

    Add trailing comma support to matches macro
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    383da5e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#76074 - richkadel:llvm-coverage-map-gen-6b.…

    …5.1, r=wesleywiser
    
    Add new `-Z dump-mir-spanview` option
    
    Similar to `-Z dump-mir-graphviz`, this adds the option to write
    HTML+CSS files that allow users to analyze the spans associated with MIR
    elements (by individual statement, just terminator, or overall basic
    block).
    
    This PR was split out from PR rust-lang#76004, and exposes an API for spanview
    HTML+CSS files that is also used to analyze code regions chosen for
    coverage instrumentation (in a follow-on PR).
    
    Rust compiler MCP rust-lang/compiler-team#278
    
    Relevant issue: rust-lang#34701 - Implement support for LLVMs code coverage
    instrumentation
    
    r? @tmandry
    FYI @wesleywiser
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5f28831 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#76088 - hbina:add_example, r=LukasKalbertodt

    Add more examples to lexicographic cmp on Iterators.
    
    Given two arrays of T1 and T2, the most important rule of lexicographical comparison is that two arrays
    of equal length will be compared until the first difference occured.
    
    The examples provided only focuses on the second rule that says that the
    shorter array will be filled with some T2 that is less than every T1.
    Which is only possible because of the first rule.
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    7c1c7de View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#76099 - camelid:patch-8, r=jyn514

    Add info about `!` and `impl Trait`
    
    Fixes rust-lang#76094.
    
    @rustbot modify labels: T-doc C-enhancement
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    34c8b7a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#76126 - camelid:crate-list-font, r=Guillaum…

    …eGomez
    
    Use "Fira Sans" for crate list font
    
    Fira Sans is what's used for module lists and other item lists.
    Previously, the default body font, "Source Serif Pro", was used for
    crate lists, which didn't visually match other item lists.
    
    @rustbot modify labels: T-rustdoc
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    9a05582 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#76132 - Aaron1011:mac-call-stmt, r=petroche…

    …nkov
    
    Factor out StmtKind::MacCall fields into `MacCallStmt` struct
    
    In PR rust-lang#76130, I add a fourth field, which makes using a tuple variant
    somewhat unwieldy.
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    738b8ea View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#76143 - jyn514:duplicate-builtin-macros, r=…

    …petrochenkov
    
    Give a better error message for duplicate built-in macros
    
    Minor follow-up to rust-lang#75176 giving a better error message for duplicate builtin macros. This would have made it a little easier to debug.
    
    r? @petrochenkov
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    b01d0b1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76158 - mati865:self-contained-option, r=pe…

    …trochenkov
    
    Stabilise link-self-contained option
    
    MCP has been accepted: rust-lang/compiler-team#343
    
    I'll add improved heuristic in next PR.
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4a6aa35 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#76201 - denisvasilik:intra-doc-links-core-p…

    …anic, r=kennytm
    
    Move to intra-doc links for library/core/src/panic.rs
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
    
    Known issues:
    
    * Link from `core` to `std` (rust-lang#74481):
    
        [`set_hook`]
        [`String`]
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    17fa733 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#76206 - CDirkx:const-ipv6, r=ecstatic-morse

    Make all methods of `std::net::Ipv6Addr` const
    
    Make the following methods of `std::net::Ipv6Addr` unstable const under the `const_ipv6` feature:
    - `segments`
    - `is_unspecified`
    - `is_loopback`
    - `is_global` (unstable)
    - `is_unique_local`
    - `is_unicast_link_local_strict`
    - `is_documentation`
    - `multicast_scope`
    - `is_multicast`
    - `to_ipv4_mapped`
    - `to_ipv4`
    
    This would make all methods of `Ipv6Addr` const.
    
    Changed the implementation of `is_unspecified` and `is_loopback` to use a `match` instead of `==`, all other methods did not require a change.
    
    All these methods are dependent on `segments`, the current implementation of which requires unstable `const_fn_transmute` ([PR#75085](rust-lang#75085)).
    
    Part of rust-lang#76205
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    11ff32f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#76207 - denisvasilik:intra-doc-links-core-c…

    …lone, r=jyn514
    
    # Move to intra-doc links for library/core/src/clone.rs
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc, A-intra-doc-links
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    7edc93b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#76212 - JesHansen:fix-lint-doc, r=jyn514

    Document lint missing_doc_code_examples is nightly-only
    
    Closes rust-lang#76194
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    c22de44 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#76218 - petrochenkov:shebang3, r=matklad

    lexer: Tiny improvement to shebang detection
    
    Lexer now discerns between regular comments and doc comments, so use that.
    The change only affects the choice of reported errors.
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    56b5de2 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#76221 - camelid:cleanup-iter-for, r=jyn514

    Clean up header in `iter` docs for `for` loops
    
    @rustbot modify labels: T-doc
    tmandry committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4dd75f8 View commit details
    Browse the repository at this point in the history