Move jointness censoring to proc_macro #76285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proc-macro API currently exposes jointness in `Punct` tokens. That is, `+` in `+one` is **non** joint. Our lexer produces jointness info for all tokens, so we need to censor it *somewhere* Previously we did this in a lexer, but it makes more sense to do this in a proc-macro server.
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Sep 3, 2020
petrochenkov
added
S-waiting-on-author
Cloning a tt is cheap, but not free (there's Arc inside).
matklad
force-pushed
the
censor-spacing
branch
from
9d3b31c
to
09d3db2
Compare
matklad
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 09d3db2 has been approved by |
bors
added
S-waiting-on-bors
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75695 (Add a regression test for issue-72793) - rust-lang#75741 (Refactor byteorder to std in rustc_middle) - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features) - rust-lang#75994 (`impl Rc::new_cyclic`) - rust-lang#76060 (Link vec doc to & reference) - rust-lang#76078 (Remove disambiguators from intra doc link text) - rust-lang#76082 (Fix intra-doc links on pub re-exports) - rust-lang#76254 (Fold length constant in Rvalue::Repeat) - rust-lang#76258 (x.py check checks tests/examples/benches) - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility) - rust-lang#76285 (Move jointness censoring to proc_macro) Failed merges: r? @ghost
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 10, 2020
Revert rust-lang#76285 Fixes rust-lang#76399. Reverting because the issue is P-critical and there are no PRs up to fix it. r? @Mark-Simulacrum cc @matklad @dtolnay
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 10, 2020
Revert rust-lang#76285 Fixes rust-lang#76399. Reverting because the issue is P-critical and there are no PRs up to fix it. r? @Mark-Simulacrum cc @matklad @dtolnay
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#74787 (Move `rustllvm` into `compiler/rustc_llvm`) - rust-lang#76458 (Add drain_filter method to HashMap and HashSet) - rust-lang#76472 (rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm) - rust-lang#76497 (Use intra-doc links in `core::ptr`) - rust-lang#76500 (Add -Zgraphviz_dark_mode and monospace font fix) - rust-lang#76543 (Document btree's unwrap_unchecked) - rust-lang#76556 (Revert rust-lang#76285) Failed merges: r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2020
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? `@petrochenkov`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proc-macro API currently exposes jointness in
Puncttokens. That is,+in+oneis non joint.Our lexer produces jointness info for all tokens, so we need to censor
it somewhere
Previously we did this in a lexer, but it makes more sense to do this
in a proc-macro server.
r? @petrochenkov