Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add as_str() to string::Drain. #76525

Merged
merged 6 commits into from
Sep 19, 2020
Merged

Add as_str() to string::Drain. #76525

merged 6 commits into from
Sep 19, 2020

Commits on Sep 9, 2020

  1. Add as_str() and AsRef to string::Drain.

    @m-ou-se
    m-ou-se committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    daa62d9 View commit details
    Browse the repository at this point in the history

  2. Show remaining data in string::Drain's Debug impl.

    @m-ou-se
    m-ou-se committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    6732840 View commit details
    Browse the repository at this point in the history

  3. Add AsRef<[u8]> for String's Drain.

    @m-ou-se
    m-ou-se committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    f5bb523 View commit details
    Browse the repository at this point in the history

  4. Mark AsRef impls for String's Drain as stable. 

    Trait implementations effectively can't be #[unstable].
    @m-ou-se
    m-ou-se committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    f2a3290 View commit details
    Browse the repository at this point in the history

  5. Disable AsRef implementations for String's Drain. 

    Since trait implementations cannot be unstable, we should only add them
when the as_str feature gets stabilized. Until then, only `.as_str()` is
available (behind a feature gate).
    @m-ou-se
    m-ou-se committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    829019d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Add tracking issue number for string_drain_as_str.

    @m-ou-se
    m-ou-se committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    15eb638 View commit details
    Browse the repository at this point in the history