Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host triples to CI builders #76639

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This is a follow-up to #76415, which changed how x.py interprets cross-compilation target/host flags. This should fix the known cases, but I'm still working through CI logs before/after that PR to identify if anything else is missing.

@Mark-Simulacrum
Copy link
Member Author

I will work through the rest of the CI logs, but that'll take some time. We have until tonight's nightly to land this PR (if we want it fixed ASAP).

r? @pietroalbini

@Mark-Simulacrum
Copy link
Member Author

I've checked the two CI upload buckets and I think after this PR the artifacts we publish should be good. I'm still downloading CI logs to check tests etc.

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2020
It is really painful to inspect differences in what was built in CI if things
are appearing and disappearing randomly as they hover around the 100ms mark. No
matter what we choose there's always going to be quite a bit of variability on
CI in timing, so we're going to see things appear and vanish.
@Mark-Simulacrum
Copy link
Member Author

Okay, it turns out we don't print all timings, just those above 100ms which makes comparing logs quite painful, but I think I can explain most of the differences by that 100ms barrier. I also added a commit here which disables that 100ms marker so that we can, in the future, more readily compare CI logs without running into this problem.

@pietroalbini
Copy link
Member

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Sep 12, 2020

📌 Commit e788b1a has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2020
@bors
Copy link
Contributor

bors commented Sep 12, 2020

⌛ Testing commit e788b1a with merge 7adeb2c...

@bors
Copy link
Contributor

bors commented Sep 12, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 7adeb2c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2020
@bors bors merged commit 7adeb2c into rust-lang:master Sep 12, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 12, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2020
…oalbini

Add host triples to target lists

This PR is primarily intended to fix rust-lang/rustup#2494, which is the second commit. That bug was introduced by rust-lang#76415, and incompletely fixed by rust-lang#76639. (rust-lang#76639 added host triples, which gave us compilers, but missed that we also need documentation and other target-only things). However, it also removes duplicate macOS CI builders.

r? `@pietroalbini`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants