Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIR pass to remove unneeded drops on types not needing drop #76673

Merged
merged 7 commits into from
Sep 23, 2020
Merged

MIR pass to remove unneeded drops on types not needing drop #76673

merged 7 commits into from
Sep 23, 2020

Commits on Sep 22, 2020

  1. MIR pass to remove unneeded drops on types not needing drop 

    This is heavily dependent on MIR inlining running to actually see the drop statement
    @simonvandel
    simonvandel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    290dca1 View commit details
    Browse the repository at this point in the history

  2. Suggestion from review 

    Co-authored-by: Andreas Jonson <andjo403@users.noreply.github.com>
    @simonvandel @andjo403
    simonvandel and andjo403 committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b4bdaa1 View commit details
    Browse the repository at this point in the history

  3. Get LocalDefId from source instead of passing in

    @simonvandel
    simonvandel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    d3338dc View commit details
    Browse the repository at this point in the history

  4. The optimization should also apply for DropAndReplace

    @simonvandel
    simonvandel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    f472303 View commit details
    Browse the repository at this point in the history

  5. cleanup cfg after optimization

    @simonvandel
    simonvandel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b6f51d6 View commit details
    Browse the repository at this point in the history

  6. rebless after rebase

    @simonvandel
    simonvandel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    ff24163 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Ignore test on wasm as it does not unwind

    @simonvandel
    simonvandel committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    05f84c6 View commit details
    Browse the repository at this point in the history