Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename mir-opt diff tests with 32/64 bit #76854

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Rename mir-opt diff tests with 32/64 bit #76854

merged 4 commits into from
Sep 18, 2020

Conversation

aDotInTheVoid
Copy link
Member

Now syntax highlighting should work.

I've tested that --bless works localy, but I'm not sure it's possible on CI

Fixes #75746

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@aDotInTheVoid aDotInTheVoid force-pushed the mir-opt-32-64-diff-name branch from 19553cf to 735776d Compare September 17, 2020 23:03
oli-obk
oli-obk reviewed Sep 18, 2020
View reviewed changes
src/test/mir-opt/graphviz.main.mir_map.0.dot.mir
@@ -0,0 +1,10 @@
digraph Mir_0_3 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally committed file?

oli-obk
oli-obk reviewed Sep 18, 2020
View reviewed changes
src/test/mir-opt/spanview_block.main.mir_map.0.html.mir
@@ -0,0 +1,67 @@
<!DOCTYPE html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here?

@oli-obk
Copy link
Contributor

oli-obk commented Sep 18, 2020

Ah no the new files are files we failed to emit! So this is even a bugfix, cool.

@bors r+ p=6 (bitrotty)

@bors
Copy link
Contributor

bors commented Sep 18, 2020

📌 Commit 735776d has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2020
@bors
Copy link
Contributor

bors commented Sep 18, 2020

⌛ Testing commit 735776d with merge 953f33c...

@bors
Copy link
Contributor

bors commented Sep 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 953f33c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2020
@bors bors merged commit 953f33c into rust-lang:master Sep 18, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 18, 2020
This was referenced Sep 18, 2020
Merged
Merged
Closed
Merged
@aDotInTheVoid aDotInTheVoid deleted the mir-opt-32-64-diff-name branch January 6, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

mir-opt diff tests for 64/32 bit targets doesn't render as diff in github
5 participants
@aDotInTheVoid @oli-obk @bors @rust-highfive @rustbot