Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #77001

Closed
wants to merge 39 commits into from
Closed

Commits on Aug 10, 2020

  1. Configuration menu
    Copy the full SHA
    b1375cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a22b21 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Configuration menu
    Copy the full SHA
    ee289d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Configuration menu
    Copy the full SHA
    4675a31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bffd211 View commit details
    Browse the repository at this point in the history
  3. Fix broken link

    poliorcetics committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    982ec0d View commit details
    Browse the repository at this point in the history
  4. Fix broken link

    poliorcetics committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    b534d9f View commit details
    Browse the repository at this point in the history
  5. Remove DeclareMethods

    khyperia committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    0bc405e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Configuration menu
    Copy the full SHA
    65edf54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cebbd9f View commit details
    Browse the repository at this point in the history
  3. Use as_secs_f64 in profiling.rs

    est31 committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    43193dc View commit details
    Browse the repository at this point in the history
  4. Replace write_fmt with write!

    Latter is simpler
    est31 committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    4bc0e55 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b2c5f99 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    812ff66 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c2dad1c View commit details
    Browse the repository at this point in the history
  8. Revert adding Atomic::from_mut.

    This made too many assumptions about platforms, breaking some things.
    
    Will need to be added later with a better way of gating on proper
    alignment, without hardcoding cfg(target_arch)s.
    m-ou-se committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    5ef1db3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0e56b52 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    08b85a6 View commit details
    Browse the repository at this point in the history
  11. Add non-unsafe .get_mut() for UnsafeCell

    Update the tracking issue number
    
    Updated the documentation for `UnsafeCell`
    
    Address review comments
    
    Address more review comments + minor changes
    danielhenrymantilla committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    8169989 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5886c38 View commit details
    Browse the repository at this point in the history
  13. Fix nits

    poliorcetics committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    aaddcdb View commit details
    Browse the repository at this point in the history
  14. liballoc bench use imported path Bencher

    test is already in scope, no need to use the full path
    pickfire committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    d99bb9d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    37ec045 View commit details
    Browse the repository at this point in the history
  16. Add sample defaults for config.toml

    - Allow including defaults in `src/bootstrap/defaults` using `profile = "..."`
    - Add default config files
    - Combine config files using the merge dependency.
    - Add comments to default config files
    - Add a README asking to open an issue if the defaults are bad
    - Give a loud error if trying to merge `.target`, since it's not
      currently supported
    - Use an exhaustive match
    - Use `<none>` in config.toml.example to avoid confusion
    - Fix bugs in `Merge` derives
    
    Previously, it would completely ignore the profile defaults if there
    were any settings in `config.toml`. I sent an email to the `merge` maintainer
    asking them to make the behavior in this commit the default.
    
    This introduces a new dependency on `merge` that hasn't yet been vetted.
    
    I want to improve the output when `include = "x"` isn't found:
    
    ```
    thread 'main' panicked at 'fs::read_to_string(&file) failed with No such file or directory (os error 2) ("configuration file did not exist")', src/bootstrap/config.rs:522:28
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    failed to run: /home/joshua/rustc/build/bootstrap/debug/bootstrap test tidy
    Build completed unsuccessfully in 0:00:00
    ```
    
    However that seems like it could be fixed in a follow-up.
    jyn514 committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    c9c8fb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Rollup merge of rust-lang#74225 - poliorcetics:std-thread-unsafe-op-i…

    …n-unsafe-fn, r=joshtriplett
    
    Std/thread: deny unsafe op in unsafe fn
    
    Partial fix of rust-lang#73904.
    
    This encloses `unsafe` operations in `unsafe fn` in `libstd/thread`.
    @rustbot modify labels: F-unsafe-block-in-unsafe-fn
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    be347bc View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#76628 - jyn514:default-config-files, r=Mark…

    …-Simulacrum
    
    Add sample defaults for config.toml
    
    - Allow including defaults in `src/bootstrap/defaults` using `profile = "..."`.
    - Add default config files, with a README noting they're experimental and asking you to open an issue if you run into trouble. The config files have comments explaining why the defaults are set.
    - Combine config files using the `merge` dependency.
    
    This introduces a new dependency on `merge` that hasn't yet been vetted.
    
    I want to improve the output when `include = "x"` isn't found:
    
    ```
    thread 'main' panicked at 'fs::read_to_string(&file) failed with No such file or directory (os error 2) ("configuration file did not exist")', src/bootstrap/config.rs:522:28
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    failed to run: /home/joshua/rustc/build/bootstrap/debug/bootstrap test tidy
    Build completed unsuccessfully in 0:00:00
    ```
    
    However that seems like it could be fixed in a follow-up.
    
    Closes rust-lang#76619
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    eb0f3dd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#76867 - poliorcetics:intra-doc-core-iter, r…

    …=jyn514
    
    Use intra-doc links in core/src/iter when possible
    
    Helps with rust-lang#75080.
    
    I also updated lots of links to use `fn()` instead of `fn` when possible.
    
    @rustbot modify labels: T-doc A-intra-doc-links
    
    r? @jyn514
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    d93e2b6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#76868 - poliorcetics:intra-doc-std-sync, r=…

    …jyn514
    
    Finish moving to intra doc links for std::sync
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc A-intra-doc-links
    
    r? @jyn514
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a44e0b0 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#76872 - khyperia:remove_declare_methods, r=…

    …eddyb
    
    Remove DeclareMethods
    
    Most of the `DeclareMethods` API was only used internally by rustc_codegen_llvm. As such, it makes no sense to require other backends to implement them.
    
    (`get_declared_value` and `declare_cfn` were used, in one place, specific to the `main` symbol, which I've replaced with a more specialized function to allow more flexibility in implementation - the intent is that `declare_c_main` can go away once we do something more clever, e.g. @eddyb has ideas around having a MIR shim or somesuch we can explore in a follow-up PR)
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    d79401c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#76936 - danielhenrymantilla:unsafecell_get_…

    …mut, r=RalfJung
    
    Add non-`unsafe` `.get_mut()` for `Unsafecell`
    
      - Tracking issue: rust-lang#76943
    
    As discussed in: https://internals.rust-lang.org/t/add-non-unsafe-get-mut-for-unsafecell/12407
    
      - ### [Rendered documentation](https://modest-dubinsky-1f9f47.netlify.app/core/cell/struct.unsafecell)
    
    This PR tries to move the sound `&mut UnsafeCell<T> -> &mut T` projection that all the "downstream" constructions were already relying on, up to the root abstraction, where it rightfully belongs, and officially blessing it.
    
      - this **helps reduce the amount of `unsafe` snippets out there** (_c.f._, the second commit of this PR: rust-lang@09503fd)
    
    The fact that this getter is now expose for `UnsafeCell<T>` itself, will also help convey the idea that **`UnsafeCell` is not magical _w.r.t._ `&mut` accesses**, contrary to what some people incorrectly think.
    
      - Even the standard library itself at some point had such a confusion, _c.f._ this comment where there is a mention of multi-threaded (and thus _shared_) access despite dealing with exclusive references over unique ownership: https://github.com/rust-lang/rust/blob/59fb88d061544a035f3043b47594b34789204cee/library/core/src/cell.rs#L498-L499
    
    r? @RalfJung
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    1f8ee01 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#76958 - est31:ns, r=oli-obk

    Replace manual as_nanos and as_secs_f64 reimplementations
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    fe325cc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76959 - est31:write, r=oli-obk

    Replace write_fmt with write!
    
    Latter is simpler
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    19c382a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    18d1b1b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#76962 - est31:const_cstr, r=oli-obk

    Use const_cstr macro in consts.rs
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    62a2e1f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#76963 - est31:remove_static_assert, r=oli-obk

    Remove unused static_assert macro
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7261beb View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#76967 - fusion-engineering-forks:revert-ato…

    …mic-from-mut, r=kodrAus
    
    Revert adding Atomic::from_mut.
    
    This reverts rust-lang#74532, which made too many assumptions about platforms, breaking some things.
    
    Will need to be added later with a better way of gating on proper alignment, without hardcoding cfg(target_arch)s.
    
    ---
    
    To be merged if fixing from_mut (rust-lang#76965) takes too long.
    
    r? @ghost
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7d1cd3a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#76977 - tmiasko:issue-76740, r=wesleywiser

    Add a regression test for copy propagation miscompilation
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ab68b8b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#76981 - pickfire:patch-5, r=Mark-Simulacrum

    liballoc bench use imported path Bencher
    
    test is already in scope, no need to use the full path
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    5f47246 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#76983 - ssomers:btree_extra_test, r=Mark-Si…

    …mulacrum
    
    BTreeMap: extra testing & fixed comments
    
    r? @Mark-Simulacrum
    RalfJung committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    6ef1377 View commit details
    Browse the repository at this point in the history