Commits on Oct 5, 2020

1. Updates to experimental coverage counter injection …

   This is a combination of 18 commits.
   
   Commit #2:
   
   Additional examples and some small improvements.
   
   Commit #3:
   
   fixed mir-opt non-mir extensions and spanview title elements
   
   Corrected a fairly recent assumption in runtest.rs that all MIR dump
   files end in .mir. (It was appending .mir to the graphviz .dot and
   spanview .html file names when generating blessed output files. That
   also left outdated files in the baseline alongside the files with the
   incorrect names, which I've now removed.)
   
   Updated spanview HTML title elements to match their content, replacing a
   hardcoded and incorrect name that was left in accidentally when
   originally submitted.
   
   Commit #4:
   
   added more test examples
   
   also improved Makefiles with support for non-zero exit status and to
   force validation of tests unless a specific test overrides it with a
   specific comment.
   
   Commit #5:
   
   Fixed rare issues after testing on real-world crate
   
   Commit #6:
   
   Addressed PR feedback, and removed temporary -Zexperimental-coverage
   
   -Zinstrument-coverage once again supports the latest capabilities of
   LLVM instrprof coverage instrumentation.
   
   Also fixed a bug in spanview.
   
   Commit #7:
   
   Fix closure handling, add tests for closures and inner items
   
   And cleaned up other tests for consistency, and to make it more clear
   where spans start/end by breaking up lines.
   
   Commit #8:
   
   renamed "typical" test results "expected"
   
   Now that the `llvm-cov show` tests are improved to normally expect
   matching actuals, and to allow individual tests to override that
   expectation.
   
   Commit #9:
   
   test coverage of inline generic struct function
   
   Commit #10:
   
   Addressed review feedback
   
   * Removed unnecessary Unreachable filter.
   * Replaced a match wildcard with remining variants.
   * Added more comments to help clarify the role of successors() in the
   CFG traversal
   
   Commit #11:
   
   refactoring based on feedback
   
   * refactored `fn coverage_spans()`.
   * changed the way I expand an empty coverage span to improve performance
   * fixed a typo that I had accidently left in, in visit.rs
   
   Commit #12:
   
   Optimized use of SourceMap and SourceFile
   
   Commit #13:
   
   Fixed a regression, and synched with upstream
   
   Some generated test file names changed due to some new change upstream.
   
   Commit #14:
   
   Stripping out crate disambiguators from demangled names
   
   These can vary depending on the test platform.
   
   Commit #15:
   
   Ignore llvm-cov show diff on test with generics, expand IO error message
   
   Tests with generics produce llvm-cov show results with demangled names
   that can include an unstable "crate disambiguator" (hex value). The
   value changes when run in the Rust CI Windows environment. I added a sed
   filter to strip them out (in a prior commit), but sed also appears to
   fail in the same environment. Until I can figure out a workaround, I'm
   just going to ignore this specific test result. I added a FIXME to
   follow up later, but it's not that critical.
   
   I also saw an error with Windows GNU, but the IO error did not
   specify a path for the directory or file that triggered the error. I
   updated the error messages to provide more info for next, time but also
   noticed some other tests with similar steps did not fail. Looks
   spurious.
   
   Commit #16:
   
   Modify rust-demangler to strip disambiguators by default
   
   Commit #17:
   
   Remove std::process::exit from coverage tests
   
   Due to Issue rust-lang#77553, programs that call std::process::exit() do not
   generate coverage results on Windows MSVC.
   
   Commit #18:
   
   fix: test file paths exceeding Windows max path len

   

   richkadel committed Oct 5, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f5aebad
   • Browse repository at this point

   Copy the full SHA

   f5aebad View commit details

   Browse the repository at this point in the history

2. Renamed tests to avoid exceeding Windows max path limit

   

   richkadel committed Oct 5, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 6f62766
   • Browse repository at this point

   Copy the full SHA

   6f62766 View commit details

   Browse the repository at this point in the history