Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability annotations on generic parameters (take 2.5) #77118

Merged
merged 20 commits into from
Sep 27, 2020

Conversation

exrook
Copy link
Contributor

@exrook exrook commented Sep 23, 2020

Rebase of #72314 + more tests

Implements rust-lang/wg-allocators#2.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2020
@varkor
Copy link
Member

varkor commented Sep 23, 2020

Thanks for taking this across the finish line!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2020

📌 Commit 98eab09 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2020
@varkor
Copy link
Member

varkor commented Sep 23, 2020

Thanks to @Avi-D-coder for all their hard work implementing this feature!

@bors
Copy link
Contributor

bors commented Sep 27, 2020

⌛ Testing commit 98eab09 with merge d902752...

@bors
Copy link
Contributor

bors commented Sep 27, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: varkor
Pushing d902752 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2020
@bors bors merged commit d902752 into rust-lang:master Sep 27, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 27, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2020
Support custom allocators in `Box`

r? `@Amanieu`

This pull request requires a crater run.

### Prior work:
- rust-lang#71873
- rust-lang#58457
- [`alloc-wg`](https://github.com/TimDiekmann/alloc-wg)-crate

Currently blocked on:
- ~rust-lang#77118~
- ~rust-lang/chalk#615 (rust-lang#77515)~
@TimDiekmann
Copy link
Member

TimDiekmann commented Nov 28, 2020

When adding an unstable generic parameter to String, this results in the following error:

error: This stability annotation is useless
   --> library/alloc/src/string.rs:280:75
    |
280 | pub struct String<#[unstable(feature = "allocator_api", issue = "32838")] A: AllocRef = Global> {
    |                                                                           ^

error: This stability annotation is useless
   --> library/alloc/src/string.rs:319:82
    |
319 | pub struct FromUtf8Error<#[unstable(feature = "allocator_api", issue = "32838")] A: AllocRef = Global>  {
    |             

Is this a bug in this implementation or is this a false positive of the compiler when searching for stability annotations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants