Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try enabling typeof for fun error messages #77246

Merged
merged 4 commits into from
Apr 27, 2021
Merged

try enabling typeof for fun error messages #77246

merged 4 commits into from
Apr 27, 2021

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented Sep 26, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
@yaahc yaahc marked this pull request as draft September 26, 2020 23:34
@yaahc
Copy link
Member Author

yaahc commented Sep 26, 2020

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned varkor Sep 26, 2020
@Dylan-DPC-zz
Copy link

@yaahc if you can fix the CI we can take this pr forward

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@yaahc
Copy link
Member Author

yaahc commented Oct 23, 2020

@yaahc if you can fix the CI we can take this pr forward

@Dylan-DPC it will probably be a bit before I get to this but 👍

@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

r? @oli-obk

if you want, we can also close this PR and open an E-easy issue. Then someone can copy your PR and update all the tests (or write some more)

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Dec 28, 2020
@yaahc
Copy link
Member Author

yaahc commented Dec 29, 2020

r? @oli-obk

if you want, we can also close this PR and open an E-easy issue. Then someone can copy your PR and update all the tests (or write some more)

I think I want to try to finish this one, since I know it's supposed to be easy.

@jyn514
Copy link
Member

jyn514 commented Apr 16, 2021

@yaahc are you still planning to work on this?

@yaahc
Copy link
Member Author

yaahc commented Apr 16, 2021

yea, sorry about that, this fell off my radar completely but I have a lot more bandwidth for this now (once I get a working dev machine setup again, laptop battery started expanding a couple days ago). So yea, to answer your question, yes, still planning on working on this and soon.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc yaahc marked this pull request as ready for review April 23, 2021 21:36
@yaahc yaahc added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Apr 24, 2021

The impl lgtm. Please add a test showcasing the new error messages

@oli-obk
Copy link
Contributor

oli-obk commented Apr 27, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Apr 27, 2021

📌 Commit ed903f9 has been approved by oli-obk

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2021
@bors
Copy link
Contributor

bors commented Apr 27, 2021

⌛ Testing commit ed903f9 with merge 22b686a...

@bors
Copy link
Contributor

bors commented Apr 27, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 22b686a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2021
@bors bors merged commit 22b686a into rust-lang:master Apr 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 27, 2021
@bors bors mentioned this pull request Apr 27, 2021
Merged
@yaahc yaahc deleted the typeof-errors branch April 27, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
10 participants
@yaahc @rust-highfive @Dylan-DPC-zz @oli-obk @jyn514 @rust-log-analyzer @bors @eddyb @varkor @rustbot