Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liveness refactoring continued #77274

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Liveness refactoring continued #77274

merged 6 commits into from
Sep 29, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 27, 2020 •
edited
Loading

  • Move body_owner field from IrMaps to Liveness (the only user of the field).
  • Use upvars instead of FnKind to check for closures (avoids FnKind, will be useful when checking all bodies, not just fns).
  • Use visit_param to add variables corresponding to params.
  • Store upvars_mentioned inside Liveness struct.
  • Inline visitor implementation for IrMaps, avoiding unnecessary indirection.
  • Test interaction with automatically_derived attribute (not covered by any of existing tests).

No functional changes intended.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2020
@tmiasko tmiasko mentioned this pull request Sep 27, 2020
Merged
@lcnr
Copy link
Contributor

lcnr commented Sep 28, 2020

I am extremely impressed ❤️

@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2020

📌 Commit 063d5e9 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#77274 - tmiasko:liveness-cnd, r=lcnr
c789c5e 
Liveness refactoring continued

* Move body_owner field from IrMaps to Liveness (the only user of the field).
* Use upvars instead of FnKind to check for closures (avoids FnKind, will be useful when checking all bodies, not just fns).
* Use visit_param to add variables corresponding to params.
* Store upvars_mentioned inside Liveness struct.
* Inline visitor implementation for IrMaps, avoiding unnecessary indirection.
* Test interaction with automatically_derived attribute (not covered by any of existing tests).

No functional changes intended.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 28, 2020
Closed
@bors
Copy link
Contributor

bors commented Sep 29, 2020

⌛ Testing commit 063d5e9 with merge 381b445...

@bors
Copy link
Contributor

bors commented Sep 29, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: lcnr
Pushing 381b445 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2020
@bors bors merged commit 381b445 into rust-lang:master Sep 29, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 29, 2020
@tmiasko tmiasko deleted the liveness-cnd branch September 29, 2020 21:45
This was referenced Sep 29, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tmiasko @lcnr @bors @rust-highfive @rustbot