Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ty::TyKind to ty::TyData, Ty::kind to Ty::data #77768

Closed
wants to merge 1 commit into from
Closed

Rename ty::TyKind to ty::TyData, Ty::kind to Ty::data #77768

wants to merge 1 commit into from

Conversation

vandenheuvel
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2020
@jackh726
Copy link
Member

jackh726 commented Oct 9, 2020 •
edited
Loading

MCP: rust-lang/compiler-team#359

@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 9, 2020
@vandenheuvel vandenheuvel marked this pull request as ready for review October 9, 2020 22:28
@vandenheuvel vandenheuvel marked this pull request as draft October 9, 2020 22:28
@vandenheuvel vandenheuvel marked this pull request as ready for review October 10, 2020 09:44
@vandenheuvel
Copy link
Contributor Author

@eddyb perhaps you could look at this after the MCP is accepted?

@rustbot r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned jackh726 Oct 10, 2020
@vandenheuvel
Copy link
Contributor Author

@jackh726 perhaps you could signal your 'LGTM' from zulip also here?

@LeSeulArtichaut LeSeulArtichaut added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Oct 10, 2020
jackh726
jackh726 approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, basically just a simple rename. But there are some objections on zulip that I would like to resolve.

@jyn514
Copy link
Member

jyn514 commented Oct 10, 2020

The MCP has not yet been accepted, this shouldn't be merged until it is.

@LeSeulArtichaut LeSeulArtichaut removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2020
@bors
Copy link
Contributor

bors commented Oct 10, 2020

☔ The latest upstream changes (presumably #77798) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 10, 2020
@vandenheuvel
Copy link
Contributor Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2020
@vandenheuvel
Copy link
Contributor Author

vandenheuvel commented Oct 11, 2020 •
edited
Loading

@jackh726

this LGTM, basically just a simple rename. But there are some objections on zulip that I would like to resolve.

I asked @eddyb to review as he had some points on Zulip still around the time that I made this PR.

@jyn514

The MCP has not yet been accepted, this shouldn't be merged until it is.

I agree, I included this in my request for review. I think the 10 days have passed now, right? Is the "accepted" label not applied automatically? I left the S-waiting-on-fcp label for now.

@bors
Copy link
Contributor

bors commented Oct 14, 2020

☔ The latest upstream changes (presumably #77926) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@LeSeulArtichaut
Copy link
Contributor

I'm going to close this as the MCP is going to be rejected.

Thank you so much @vandenheuvel for taking the time to implement this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@jackh726 jackh726 jackh726 approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vandenheuvel @rust-highfive @jackh726 @jyn514 @bors @LeSeulArtichaut @lcnr @eddyb @rustbot