Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc: Fix macros 2.0 and built-in derives being shown at the wrong path #77862

Merged
merged 12 commits into from
Jan 10, 2021
Merged

Rustdoc: Fix macros 2.0 and built-in derives being shown at the wrong path #77862

merged 12 commits into from
Jan 10, 2021

Commits on Jan 6, 2021

  1. Rustdoc: Fix macros 2.0 and built-in derives being shown at the wrong… 

    … path.

Fixes rust-lang#74355

The issue with the built-in derives may be related to:
rust-lang#55482 (comment)
    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0bee802 View commit details
    Browse the repository at this point in the history

  2. Implement suggestions from code review.

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7d03870 View commit details
    Browse the repository at this point in the history

  3. Fix type/value namespace clashes + test for that

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d3a33eb View commit details
    Browse the repository at this point in the history

  4. Style nit: replace for_each & return with for & continue 

    Co-Authored-By: Joshua Nelson <jyn514@gmail.com>
    @danielhenrymantilla @jyn514
    danielhenrymantilla and jyn514 committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    aa863ca View commit details
    Browse the repository at this point in the history

  5. Update test assertions (showcases bug)

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    28e9c67 View commit details
    Browse the repository at this point in the history

  6. WIP: attempt to fix the undocument re-export issue

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dd15f41 View commit details
    Browse the repository at this point in the history

  7. Enhance tests based on code review 

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    @danielhenrymantilla
    danielhenrymantilla and Joshua Nelson committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8df6066 View commit details
    Browse the repository at this point in the history

  8. Style nit: avoid confusing name shadowing in pattern match 

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    @danielhenrymantilla
    danielhenrymantilla and Joshua Nelson committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ce3ecd6 View commit details
    Browse the repository at this point in the history

  9. Fix ICE on pub macros defined within a non-module type namespace.

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    255f107 View commit details
    Browse the repository at this point in the history

  10. Fixed non-declarative-nor-opaque macros effective privacy. 

    cc @petrochenkov
    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a4de27a View commit details
    Browse the repository at this point in the history

  11. Fix rebase and clean up some code.

    @danielhenrymantilla
    danielhenrymantilla committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0311fe9 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Apply suggestions from code review & other minor nits 

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    @danielhenrymantilla
    danielhenrymantilla and Joshua Nelson committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    bceb173 View commit details
    Browse the repository at this point in the history