Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tuple of infer vars for upvar_tys with single infer var #77873

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Replace tuple of infer vars for upvar_tys with single infer var #77873

merged 4 commits into from
Oct 15, 2020

Commits on Oct 11, 2020

  1. Replace tuple of infer vars for upvar_tys with single infer var 

    This commit allows us to decide the number of captures required after
completing capture ananysis, which is required as part of implementing
RFC-2229.

Co-authored-by: Aman Arora <me@aman-arora.com>
Co-authored-by: Jenny Wills <wills.jenniferg@gmail.com>
    @roxelo @arora-aman @jenniferwills
    3 people committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    dc18370 View commit details
    Browse the repository at this point in the history

  2. Always return tupled_upvar_tys for Closure/Generator consituent tys 

    Depending on if upvar_tys inferred or not, we were returning either an
inference variable which later resolves to a tuple or else the upvar tys
themselves

Co-authored-by: Roxane Fruytier <roxane.fruytier@hotmail.com>
    @arora-aman @roxelo
    arora-aman and roxelo committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    08d1ab0 View commit details
    Browse the repository at this point in the history

  3. traits diagnostics: Don't print closure/generator upvar_tys tuple 

    Co-authored-by: Roxane Fruytier <roxane.fruytier@hotmail.com>
    @arora-aman @roxelo
    arora-aman and roxelo committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    3c46fd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Address comments

    @roxelo
    roxelo committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a64ad51 View commit details
    Browse the repository at this point in the history