Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unignore test for #36710 on MUSL #77901

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Unignore test for #36710 on MUSL #77901

merged 7 commits into from
Oct 25, 2020

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Oct 13, 2020 •
edited
Loading

This now works fine thanks to autodetected -C link-self-contained.

Closes #36710

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2020
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jonas-schievink jonas-schievink changed the title [WIP] Unignore test for #36710 on MUSL Unignore test for #36710 on MUSL Oct 14, 2020
@jonas-schievink jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 15, 2020
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2020

📌 Commit 46f6d8e5c4fa2a01ec34c62b9787d3dddedd12a6 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2020
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy just in case

@bors
Copy link
Contributor

bors commented Oct 16, 2020

⌛ Testing commit 46f6d8e5c4fa2a01ec34c62b9787d3dddedd12a6 with merge 7433f9955399524a24b607524e3fd39743a9d481...

@bors
Copy link
Contributor

bors commented Oct 16, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2020
@jonas-schievink
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 16, 2020

📌 Commit 3477514 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 17, 2020
@Dylan-DPC
Rollup merge of rust-lang#77901 - jonas-schievink:unignore-test-36710…
1f34860 
…, r=Mark-Simulacrum

Unignore test for rust-lang#36710 on MUSL

This now works fine thanks to autodetected `-C link-self-contained`.

Closes rust-lang#36710
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 17, 2020
Closed
@bors
Copy link
Contributor

bors commented Oct 17, 2020

⌛ Testing commit 3477514 with merge 5b9c243352c7e0d248bef54e44eade756f7cdb2a...

@bors
Copy link
Contributor

bors commented Oct 17, 2020

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 17, 2020
jonas-schievink and others added 4 commits October 19, 2020 16:37
@jonas-schievink
Move issue-36710 test to run-make
e36de6b 
Somewhat hacky to reuse `tools.mk` like this, we should probably migrate
most of them now
@jonas-schievink
Ignore test on WASM
a671604
@jonas-schievink
ignore-thumb
d7c7649
Ignore on 32-bit targets
60594b1
@jonas-schievink
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 19, 2020

📌 Commit 60594b1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 22, 2020
@Dylan-DPC
Rollup merge of rust-lang#77901 - jonas-schievink:unignore-test-36710…
80897de 
…, r=Mark-Simulacrum

Unignore test for rust-lang#36710 on MUSL

This now works fine thanks to autodetected `-C link-self-contained`.

Closes rust-lang#36710
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 22, 2020
Closed
@bors
Copy link
Contributor

bors commented Oct 22, 2020

⌛ Testing commit 60594b1 with merge e37cb9d779cc5524b5163e2c79094efed94afcb2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 22, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2020
@jonas-schievink
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#77901 - jonas-schievink:unignore-test-36710…
66fed47 
…, r=Mark-Simulacrum

Unignore test for rust-lang#36710 on MUSL

This now works fine thanks to autodetected `-C link-self-contained`.

Closes rust-lang#36710
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 25, 2020
Closed
@bors
Copy link
Contributor

bors commented Oct 25, 2020

⌛ Testing commit 60594b1 with merge 0dce3f6...

@bors
Copy link
Contributor

bors commented Oct 25, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0dce3f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2020
@bors bors merged commit 0dce3f6 into rust-lang:master Oct 25, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 25, 2020
@jonas-schievink jonas-schievink deleted the unignore-test-36710 branch October 25, 2020 18:52
@tgnottingham tgnottingham mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

link: failed to static link to c++ library when global variable is used
7 participants
@jonas-schievink @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @pietroalbini @rustbot