Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Revert "Promote missing_fragment_specifier to hard error #75516" #78146

Merged
merged 3 commits into from
Nov 7, 2020
Merged

[beta] Revert "Promote missing_fragment_specifier to hard error #75516" #78146

merged 3 commits into from
Nov 7, 2020

Conversation

Mark-Simulacrum
Copy link
Member

This reverts "Promote missing_fragment_specifier to hard error #75516" on just beta. I would like us to explore a more principled fix, perhaps along the lines @petrochenkov suggested in #76605, on master when we have more time to test it but I don't want us shipping the breakage in the meantime. I don't personally feel comfortable immediately backporting anything more than a revert here.

cc @matklad

This matches #77456 for 1.47 but targets 1.48 (current beta) instead.

r? @petrochenkov

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=never

@matklad
Copy link
Member

matklad commented Oct 20, 2020

👍 from me on reverting

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2020

📌 Commit 62bcdae821e466500edc05ec9b4c5b8311ebfa3c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2020
@bors
Copy link
Contributor

bors commented Oct 22, 2020

⌛ Testing commit 62bcdae821e466500edc05ec9b4c5b8311ebfa3c with merge 9bfd49783341567fe637193d584d344fdc8ba76b...

@bors
Copy link
Contributor

bors commented Oct 22, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2020
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2020
@jonas-schievink
Copy link
Contributor

@bors r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2020
@petrochenkov
Copy link
Contributor

Looks like some UI tests need an update?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum force-pushed the revert-76605 branch 3 times, most recently from 8e3766d to c279138 Compare November 6, 2020 19:50
@Mark-Simulacrum
Copy link
Member Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Nov 6, 2020

📌 Commit 653c9ee has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=never

@bors
Copy link
Contributor

bors commented Nov 7, 2020

⌛ Testing commit 653c9ee with merge 437a10f...

@bors
Copy link
Contributor

bors commented Nov 7, 2020

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 437a10f to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2020
@bors bors merged commit 437a10f into rust-lang:beta Nov 7, 2020
@rustbot rustbot added this to the 1.48.0 milestone Nov 7, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the revert-76605 branch December 10, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Mark-Simulacrum @rust-highfive @matklad @petrochenkov @bors @jonas-schievink @rustbot