Fix unreachable sub-branch detection in or-patterns #78167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
A-exhaustiveness-checking
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #78430) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
r? @varkor |
varkor
reviewed
Nov 5, 2020
src/test/ui/or-patterns/exhaustiveness-unreachable-pattern.stderr
Outdated
Show resolved
Hide resolved
|
Thanks! @bors r+ rollup |
|
📌 Commit 107a29a has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 6, 2020
Fix unreachable sub-branch detection in or-patterns The previous implementation was too eager to avoid unnecessary "unreachable pattern" warnings. I feel more confident about this implementation than I felt about the previous one. Fixes rust-lang#76836. `@rustbot` modify labels: +A-exhaustiveness-checking
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#74979 (`#![deny(unsafe_op_in_unsafe_fn)]` in sys/hermit) - rust-lang#78006 (Use Intra-doc links for std::io::buffered) - rust-lang#78167 (Fix unreachable sub-branch detection in or-patterns) - rust-lang#78514 (Allow using 1/2/3/4 for `x.py setup` options) - rust-lang#78538 (BTreeMap: document a curious assumption in test cases) - rust-lang#78559 (Add LLVM upgrades from 7 to 10 to RELEASES.md) - rust-lang#78666 (Fix shellcheck error) - rust-lang#78705 (Print a summary of which test suite failed) - rust-lang#78726 (Add link to rust website) - rust-lang#78730 (Expand explanation of reverse_bits) - rust-lang#78760 (`deny(invalid_codeblock_attributes)` for rustc_error_codes) - rust-lang#78771 (inliner: Copy unevaluated constants only after successful inlining) - rust-lang#78794 (rustc_expand: use collect_bang helper instead of manual reimplementation) - rust-lang#78795 (The renumber pass is long gone) - rust-lang#78798 (Fixing Spelling Typos) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was too eager to avoid unnecessary "unreachable pattern" warnings. I feel more confident about this implementation than I felt about the previous one.
Fixes #76836.
@rustbot modify labels: +A-exhaustiveness-checking