-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #78178
Rollup of 7 pull requests #78178
Commits on Oct 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 64839ee - Browse repository at this point
Copy the full SHA 64839eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 390883e - Browse repository at this point
Copy the full SHA 390883eView commit details
Commits on Oct 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 104c0f0 - Browse repository at this point
Copy the full SHA 104c0f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c71f68 - Browse repository at this point
Copy the full SHA 2c71f68View commit details
Commits on Oct 13, 2020
-
Reword safety guarantee of Pin::static_{ref,mut}.
Co-authored-by: Peter Todd <pete@petertodd.org>
Configuration menu - View commit details
-
Copy full SHA for f83446b - Browse repository at this point
Copy the full SHA f83446bView commit details
Commits on Oct 15, 2020
-
Co-authored-by: David Tolnay <dtolnay@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for df95dce - Browse repository at this point
Copy the full SHA df95dceView commit details
Commits on Oct 18, 2020
-
Improve wording of "cannot multiply" type error
For example, if you had this code: fn foo(x: i32, y: f32) -> f32 { x * y } You would get this error: error[E0277]: cannot multiply `f32` to `i32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32` However, that's not usually how people describe multiplication. People usually describe multiplication like how the division error words it: error[E0277]: cannot divide `i32` by `f32` --> src/lib.rs:2:7 | 2 | x / y | ^ no implementation for `i32 / f32` | = help: the trait `Div<f32>` is not implemented for `i32` So that's what this change does. It changes this: error[E0277]: cannot multiply `f32` to `i32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32` To this: error[E0277]: cannot multiply `i32` by `f32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32`
Configuration menu - View commit details
-
Copy full SHA for 7b33ae6 - Browse repository at this point
Copy the full SHA 7b33ae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 003516f - Browse repository at this point
Copy the full SHA 003516fView commit details
Commits on Oct 19, 2020
-
rustdoc: Show the correct source filename, without
.html
Previously the title would be lib.rs.html -- source if `lib.rs` was the actual source filename. Now the title is lib.rs – source (note the en dash).
Configuration menu - View commit details
-
Copy full SHA for 48060f1 - Browse repository at this point
Copy the full SHA 48060f1View commit details -
remove what seems to be an outdated comment
Even in the PR that introduced this comment, it does not seem like these locals are actually ignored -- just their `source_info` is adjusted: https://github.com/rust-lang/rust/pull/44700/files#diff-ae2f3c7e2f9744f7ef43e96072b10e98d4e3fe74a3a399a3ad8a810fbe56c520R139
Configuration menu - View commit details
-
Copy full SHA for cb33f95 - Browse repository at this point
Copy the full SHA cb33f95View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1766c6 - Browse repository at this point
Copy the full SHA c1766c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 153e843 - Browse repository at this point
Copy the full SHA 153e843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dd0bb6 - Browse repository at this point
Copy the full SHA 9dd0bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d641cb8 - Browse repository at this point
Copy the full SHA d641cb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd2d91 - Browse repository at this point
Copy the full SHA dcd2d91View commit details
Commits on Oct 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ae0e3d0 - Browse repository at this point
Copy the full SHA ae0e3d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88f5e11 - Browse repository at this point
Copy the full SHA 88f5e11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 243c8e9 - Browse repository at this point
Copy the full SHA 243c8e9View commit details
Commits on Oct 21, 2020
-
Rollup merge of rust-lang#77726 - fusion-engineering-forks:static-pin…
…, r=dtolnay Add Pin::static_ref, static_mut. This adds `Pin::static_ref` and `Pin::static_mut`, which convert a static reference to a pinned static reference. Static references are effectively already pinned, as what they refer to has to live forever and can never be moved. --- Context: I want to update the `sys` and `sys_common` mutexes/rwlocks/condvars to use `Pin<&self>` in their functions, instead of only warning in the unsafety comments that they may not be moved. That should make them a little bit less dangerous to use. Putting such an object in a `static` (e.g. through `sys_common::StaticMutex`) fulfills the requirements about never moving it, but right now there's no safe way to get a `Pin<&T>` to a `static`. This solves that.
Configuration menu - View commit details
-
Copy full SHA for ff3c8cb - Browse repository at this point
Copy the full SHA ff3c8cbView commit details -
Rollup merge of rust-lang#78002 - estebank:issue-77598, r=oli-obk
Tweak "object unsafe" errors CC rust-lang#77598.
Configuration menu - View commit details
-
Copy full SHA for 9583029 - Browse repository at this point
Copy the full SHA 9583029View commit details -
Rollup merge of rust-lang#78056 - ssomers:btree_chop_up_1, r=dtolnay
BTreeMap: split off most code of remove and split_off Putting map.rs on a diet, in addition to rust-lang#77851. r? @dtolnay
Configuration menu - View commit details
-
Copy full SHA for f8bae8b - Browse repository at this point
Copy the full SHA f8bae8bView commit details -
Rollup merge of rust-lang#78063 - camelid:improve-cannot-multiply-err…
…or, r=estebank Improve wording of "cannot multiply" type error For example, if you had this code: fn foo(x: i32, y: f32) -> f32 { x * y } You would get this error: error[E0277]: cannot multiply `f32` to `i32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32` However, that's not usually how people describe multiplication. People usually describe multiplication like how the division error words it: error[E0277]: cannot divide `i32` by `f32` --> src/lib.rs:2:7 | 2 | x / y | ^ no implementation for `i32 / f32` | = help: the trait `Div<f32>` is not implemented for `i32` So that's what this change does. It changes this: error[E0277]: cannot multiply `f32` to `i32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32` To this: error[E0277]: cannot multiply `i32` by `f32` --> src/lib.rs:2:7 | 2 | x * y | ^ no implementation for `i32 * f32` | = help: the trait `Mul<f32>` is not implemented for `i32`
Configuration menu - View commit details
-
Copy full SHA for 89c98cd - Browse repository at this point
Copy the full SHA 89c98cdView commit details -
Rollup merge of rust-lang#78094 - camelid:rustdoc-fix-source-title, r…
…=jyn514 rustdoc: Show the correct source filename in page titles, without `.html` Previously the title would be lib.rs.html -- source if `lib.rs` was the actual source filename. Now the title is lib.rs - source
Configuration menu - View commit details
-
Copy full SHA for 72ae00b - Browse repository at this point
Copy the full SHA 72ae00bView commit details -
Rollup merge of rust-lang#78101 - RalfJung:foreign-static, r=oli-obk
fix static_ptr_ty for foreign statics Cc rust-lang#74840 This does not fix that issue but fixes a problem in `static_ptr_ty` that we noticed while discussing that issue. I also added and updated a few comments. The one about `internal` locals being ignored does not seem to have been true [even in the commit that introduced it](https://github.com/rust-lang/rust/pull/44700/files#diff-ae2f3c7e2f9744f7ef43e96072b10e98d4e3fe74a3a399a3ad8a810fbe56c520R139). r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 83f126b - Browse repository at this point
Copy the full SHA 83f126bView commit details -
Rollup merge of rust-lang#78118 - spastorino:inline-const-followups, …
…r=petrochenkov Inline const followups r? @petrochenkov Follow ups of rust-lang#77124
Configuration menu - View commit details
-
Copy full SHA for de24210 - Browse repository at this point
Copy the full SHA de24210View commit details