Codegen: Query span as late as possible #78280

bugadani · 2020-10-23T12:48:35Z

No description provided.

rust-highfive · 2020-10-23T12:48:39Z

(rust_highfive has picked a reviewer for you, use r? to override)

lcnr · 2020-10-23T13:06:04Z

compiler/rustc_codegen_llvm/src/consts.rs

                    if let Some(g) = self.get_declared_value(sym) {
                        if self.val_ty(g) != self.type_ptr_to(llty) {
-                            span_bug!(span, "Conflicting types for static");
+                            span_bug!(self.tcx.def_span(def_id), "Conflicting types for static");


is there a reason you aren't using the Item span here? That seems easier to me

At the moment, it is, yes. Consider this change a step towards #43088 :)

Also I actually dont know, by the way, if these are identical, so it's kind of a "let's see what the tests think" kind of change.

the tests won't think anything here will they? This is a span_bug so we should never reach this in tests

GitHub needs a reaction that indicates how blind I can be :)

lcnr · 2020-10-23T13:07:06Z

r? @lcnr

@bors try @rust-timer queue

rust-timer · 2020-10-23T13:07:18Z

Awaiting bors try build completion

lcnr · 2020-10-23T13:16:46Z

@bors try

bors · 2020-10-23T16:56:38Z

⌛ Trying commit ee0e694620a854aa79120797a51828808e09520a with merge ecfe4ae31e98013262cabb9089048076a74d3864...

bors · 2020-10-23T16:58:03Z

💔 Test failed - checks-actions

rust-log-analyzer · 2020-10-23T17:00:05Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bugadani · 2020-10-24T08:41:26Z

Hmm, can I?
@bors try

bors · 2020-10-24T08:41:27Z

@bugadani: 🔑 Insufficient privileges: not in try users

lcnr · 2020-10-24T09:06:20Z

@bors try

bors · 2020-10-24T09:06:34Z

⌛ Trying commit c1b9d05991920c2b795c40ddb4afa030a760dbd0 with merge 3de59e1f390995a45756def4e7e157930d184b00...

bors · 2020-10-24T09:51:41Z

☀️ Try build successful - checks-actions
Build commit: 3de59e1f390995a45756def4e7e157930d184b00 (3de59e1f390995a45756def4e7e157930d184b00)

rust-timer · 2020-10-24T09:51:42Z

Queued 3de59e1f390995a45756def4e7e157930d184b00 with parent 7bade6e, future comparison URL.

rust-timer · 2020-10-24T11:30:56Z

Finished benchmarking try commit (3de59e1f390995a45756def4e7e157930d184b00): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

lcnr · 2020-10-31T17:54:56Z

completely forgot about this PR, sry.

Afaict perf was slightly positive and it seems good to land, so

@bors r+

bors · 2020-10-31T17:54:57Z

📌 Commit caf9131 has been approved by lcnr

pietroalbini · 2020-11-02T16:08:19Z

@bors retry

bors · 2020-11-02T18:29:00Z

⌛ Testing commit caf9131 with merge 53cc9ffee1ce28774351e040ee9338d677cc2ec7...

bors · 2020-11-02T18:54:25Z

💔 Test failed - checks-actions

bugadani · 2020-11-04T10:00:21Z

@pietroalbini could you please retry this again? The previous one looks like it failed with a network error:

warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/matchers/0.0.1/download`, got 502
warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/matchers/0.0.1/download`, got 502
error: failed to download from `https://crates.io/api/v1/crates/matchers/0.0.1/download`

pietroalbini · 2020-11-04T10:04:53Z

@bors retry

bors · 2020-11-04T11:04:31Z

⌛ Testing commit caf9131 with merge 2f73a3e543c922ffcd80efb5375b9b711af47bb7...

bors · 2020-11-04T11:37:32Z

💔 Test failed - checks-actions

bugadani · 2020-11-04T11:42:35Z

I'm starting to think this PR is cursed :(

pietroalbini · 2020-11-04T16:59:48Z

~~Congrats, you found a new kind of spurious failure!~~

@bors retry

bors · 2020-11-04T17:17:07Z

⌛ Testing commit caf9131 with merge 8963166...

bors · 2020-11-04T19:30:52Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 8963166 to master...

rust-highfive assigned eddyb Oct 23, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2020

lcnr reviewed Oct 23, 2020

View reviewed changes

rust-highfive assigned lcnr and unassigned eddyb Oct 23, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020

bugadani force-pushed the span branch from ee0e694 to c1b9d05 Compare October 23, 2020 17:07

Query span as late as possible

caf9131

bugadani force-pushed the span branch from c1b9d05 to caf9131 Compare October 27, 2020 09:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020

bors mentioned this pull request Nov 4, 2020

Print a summary of which test suite failed #78705

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2020

bors merged commit 8963166 into rust-lang:master Nov 4, 2020

rustbot added this to the 1.49.0 milestone Nov 4, 2020

bugadani deleted the span branch November 4, 2020 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Codegen: Query span as late as possible #78280

Codegen: Query span as late as possible #78280

bugadani commented Oct 23, 2020

rust-highfive commented Oct 23, 2020

lcnr Oct 23, 2020

bugadani Oct 23, 2020

bugadani Oct 23, 2020

lcnr Oct 23, 2020 •

edited

Loading

bugadani Oct 23, 2020

lcnr commented Oct 23, 2020 •

edited

Loading

rust-timer commented Oct 23, 2020

lcnr commented Oct 23, 2020 •

edited

Loading

bors commented Oct 23, 2020

bors commented Oct 23, 2020

rust-log-analyzer commented Oct 23, 2020

bugadani commented Oct 24, 2020

bors commented Oct 24, 2020

lcnr commented Oct 24, 2020

bors commented Oct 24, 2020

bors commented Oct 24, 2020

rust-timer commented Oct 24, 2020

rust-timer commented Oct 24, 2020

lcnr commented Oct 31, 2020

bors commented Oct 31, 2020

pietroalbini commented Nov 2, 2020

bors commented Nov 2, 2020

bors commented Nov 2, 2020

bugadani commented Nov 4, 2020

pietroalbini commented Nov 4, 2020

bors commented Nov 4, 2020

bors commented Nov 4, 2020

bugadani commented Nov 4, 2020

pietroalbini commented Nov 4, 2020

bors commented Nov 4, 2020

bors commented Nov 4, 2020

Codegen: Query span as late as possible #78280

Codegen: Query span as late as possible #78280

Conversation

bugadani commented Oct 23, 2020

rust-highfive commented Oct 23, 2020

lcnr Oct 23, 2020

Choose a reason for hiding this comment

bugadani Oct 23, 2020

Choose a reason for hiding this comment

bugadani Oct 23, 2020

Choose a reason for hiding this comment

lcnr Oct 23, 2020 • edited Loading

Choose a reason for hiding this comment

bugadani Oct 23, 2020

Choose a reason for hiding this comment

lcnr commented Oct 23, 2020 • edited Loading

rust-timer commented Oct 23, 2020

lcnr commented Oct 23, 2020 • edited Loading

bors commented Oct 23, 2020

bors commented Oct 23, 2020

rust-log-analyzer commented Oct 23, 2020

bugadani commented Oct 24, 2020

bors commented Oct 24, 2020

lcnr commented Oct 24, 2020

bors commented Oct 24, 2020

bors commented Oct 24, 2020

rust-timer commented Oct 24, 2020

rust-timer commented Oct 24, 2020

lcnr commented Oct 31, 2020

bors commented Oct 31, 2020

pietroalbini commented Nov 2, 2020

bors commented Nov 2, 2020

bors commented Nov 2, 2020

bugadani commented Nov 4, 2020

pietroalbini commented Nov 4, 2020

bors commented Nov 4, 2020

bors commented Nov 4, 2020

bugadani commented Nov 4, 2020

pietroalbini commented Nov 4, 2020

bors commented Nov 4, 2020

bors commented Nov 4, 2020

lcnr Oct 23, 2020 •

edited

Loading

lcnr commented Oct 23, 2020 •

edited

Loading

lcnr commented Oct 23, 2020 •

edited

Loading