-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #78303
Rollup of 15 pull requests #78303
Commits on Oct 7, 2020
-
Revert "Allow dynamic linking for iOS/tvOS targets."
This reverts commit 56e115a.
Configuration menu - View commit details
-
Copy full SHA for 16e10bf - Browse repository at this point
Copy the full SHA 16e10bfView commit details
Commits on Oct 11, 2020
-
revise Hermit's mutex interface to support the behaviour of StaticMutex
#77147 simplifies things by splitting this Mutex type into two types matching the two use cases: StaticMutex and MovableMutex. To support the behavior of StaticMutex, we move part of the mutex implementation into libstd.
Configuration menu - View commit details
-
Copy full SHA for 16d65d0 - Browse repository at this point
Copy the full SHA 16d65d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98fcc3f - Browse repository at this point
Copy the full SHA 98fcc3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d560b50 - Browse repository at this point
Copy the full SHA d560b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 986c1fc - Browse repository at this point
Copy the full SHA 986c1fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6e955f - Browse repository at this point
Copy the full SHA d6e955fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 530f575 - Browse repository at this point
Copy the full SHA 530f575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d8a290 - Browse repository at this point
Copy the full SHA 8d8a290View commit details
Commits on Oct 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 33fd08b - Browse repository at this point
Copy the full SHA 33fd08bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30c3dad - Browse repository at this point
Copy the full SHA 30c3dadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1741e5b - Browse repository at this point
Copy the full SHA 1741e5bView commit details
Commits on Oct 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bc6b2ac - Browse repository at this point
Copy the full SHA bc6b2acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77d9831 - Browse repository at this point
Copy the full SHA 77d9831View commit details -
box mutex to get a movable mutex
the commit avoid an alignement issue in Mutex implementation
Configuration menu - View commit details
-
Copy full SHA for bf268fe - Browse repository at this point
Copy the full SHA bf268feView commit details
Commits on Oct 18, 2020
-
#[deny(unsafe_op_in_unsafe_fn)]
in sys/cloudabichansuke committedOct 18, 2020 Configuration menu - View commit details
-
Copy full SHA for d3467fe - Browse repository at this point
Copy the full SHA d3467feView commit details
Commits on Oct 19, 2020
-
Check for exhaustion in RangeInclusive::contains
When a range has finished iteration, `is_empty` returns true, so it should also be the case that `contains` returns false.
Configuration menu - View commit details
-
Copy full SHA for b62b352 - Browse repository at this point
Copy the full SHA b62b352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fd79a3 - Browse repository at this point
Copy the full SHA 9fd79a3View commit details
Commits on Oct 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a9470d0 - Browse repository at this point
Copy the full SHA a9470d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9202fbd - Browse repository at this point
Copy the full SHA 9202fbdView commit details
Commits on Oct 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0a4d948 - Browse repository at this point
Copy the full SHA 0a4d948View commit details -
Configuration menu - View commit details
-
Copy full SHA for de76370 - Browse repository at this point
Copy the full SHA de76370View commit details -
Configuration menu - View commit details
-
Copy full SHA for de7da7f - Browse repository at this point
Copy the full SHA de7da7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e853cc0 - Browse repository at this point
Copy the full SHA e853cc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57ba8ed - Browse repository at this point
Copy the full SHA 57ba8edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40ab18d - Browse repository at this point
Copy the full SHA 40ab18dView commit details
Commits on Oct 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9775ac6 - Browse repository at this point
Copy the full SHA 9775ac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09135e4 - Browse repository at this point
Copy the full SHA 09135e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c524c - Browse repository at this point
Copy the full SHA e1c524cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e34d6 - Browse repository at this point
Copy the full SHA 50e34d6View commit details -
add
insert
andinsert_with
toOption
This removes a cause of `unwrap` and code complexity. This allows replacing ``` option_value = Some(build()); option_value.as_mut().unwrap() ``` with ``` option_value.insert(build()) ``` or ``` option_value.insert_with(build) ``` It's also useful in contexts not requiring the mutability of the reference. Here's a typical cache example: ``` let checked_cache = cache.as_ref().filter(|e| e.is_valid()); let content = match checked_cache { Some(e) => &e.content, None => { cache = Some(compute_cache_entry()); // unwrap is OK because we just filled the option &cache.as_ref().unwrap().content } }; ``` It can be changed into ``` let checked_cache = cache.as_ref().filter(|e| e.is_valid()); let content = match checked_cache { Some(e) => &e.content, None => &cache.insert_with(compute_cache_entry).content, }; ```
Configuration menu - View commit details
-
Copy full SHA for 9b90e17 - Browse repository at this point
Copy the full SHA 9b90e17View commit details -
`option.insert` covers both needs anyway, `insert_with` is redundant.
Configuration menu - View commit details
-
Copy full SHA for e8df2a4 - Browse repository at this point
Copy the full SHA e8df2a4View commit details -
more tests in option.insert, code cleaning in option
Code cleaning made according to suggestions in discussion on PR ##77392 impacts insert, get_or_insert and get_or_insert_with.
Configuration menu - View commit details
-
Copy full SHA for 60a96ca - Browse repository at this point
Copy the full SHA 60a96caView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc8b77a - Browse repository at this point
Copy the full SHA cc8b77aView commit details -
Update library/core/src/option.rs
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
Configuration menu - View commit details
-
Copy full SHA for 3955779 - Browse repository at this point
Copy the full SHA 3955779View commit details -
Update library/core/src/option.rs
Co-authored-by: Ivan Tham <pickfire@riseup.net>
Configuration menu - View commit details
-
Copy full SHA for 415a8e5 - Browse repository at this point
Copy the full SHA 415a8e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 216d0fe - Browse repository at this point
Copy the full SHA 216d0feView commit details -
Update description of Empty Enum for accuracy
An empty enum is similar to the never type `!`, rather than the unit type `()`.
Configuration menu - View commit details
-
Copy full SHA for efedcb2 - Browse repository at this point
Copy the full SHA efedcb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 972d9e8 - Browse repository at this point
Copy the full SHA 972d9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ce1e0 - Browse repository at this point
Copy the full SHA a0ce1e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 929f80e - Browse repository at this point
Copy the full SHA 929f80eView commit details -
Rollup merge of #75115 - chansuke:sys-cloudabi-unsafe, r=KodrAus
`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi Partial fix of #73904. This encloses unsafe operations in unsafe fn in sys/cloudabi.
Configuration menu - View commit details
-
Copy full SHA for eccd04c - Browse repository at this point
Copy the full SHA eccd04cView commit details -
Rollup merge of #76649 - nicbn:arc-spin-loop-hint, r=m-ou-se
Add a spin loop hint for Arc::downgrade Adds `hint::spin_loop()` to the case where `Arc::downgrade` spins.
Configuration menu - View commit details
-
Copy full SHA for 52c9f0f - Browse repository at this point
Copy the full SHA 52c9f0fView commit details -
Rollup merge of #77392 - Canop:option_insert, r=m-ou-se
add `insert` to `Option` This removes a cause of `unwrap` and code complexity. This allows replacing ``` option_value = Some(build()); option_value.as_mut().unwrap() ``` with ``` option_value.insert(build()) ``` It's also useful in contexts not requiring the mutability of the reference. Here's a typical cache example: ``` let checked_cache = cache.as_ref().filter(|e| e.is_valid()); let content = match checked_cache { Some(e) => &e.content, None => { cache = Some(compute_cache_entry()); // unwrap is OK because we just filled the option &cache.as_ref().unwrap().content } }; ``` It can be changed into ``` let checked_cache = cache.as_ref().filter(|e| e.is_valid()); let content = match checked_cache { Some(e) => &e.content, None => &cache.insert(compute_cache_entry()).content, }; ``` *(edited: I removed `insert_with`)*
Configuration menu - View commit details
-
Copy full SHA for 39b3f6b - Browse repository at this point
Copy the full SHA 39b3f6bView commit details -
Rollup merge of #77610 - hermitcore:dtors, r=m-ou-se
revise Hermit's mutex interface to support the behaviour of StaticMutex #77147 simplifies things by splitting this Mutex type into two types matching the two use cases: StaticMutex and MovableMutex. To support the new behavior of StaticMutex, we move part of the mutex implementation into libstd. The interface to the OS changed. Consequently, I removed a few functions, which aren't longer needed.
Configuration menu - View commit details
-
Copy full SHA for b0c018d - Browse repository at this point
Copy the full SHA b0c018dView commit details -
Rollup merge of #77716 - francesca64:revert-ios-dynamic-linking, r=jo…
…nas-schievink Revert "Allow dynamic linking for iOS/tvOS targets." This reverts PR #73516. On macOS I compile static libs for iOS, automated using [cargo-mobile](https://github.com/BrainiumLLC/cargo-mobile), which has worked smoothly for the past 2 years. However, upon updating to Rust 1.46.0, I was no longer able to use Rust on iOS. I've bisected this to the PR referenced above. For most projects tested, apps now immediately crash with a message like this: ``` dyld: Library not loaded: /Users/francesca/Projects/example/target/aarch64-apple-ios/debug/deps/libexample.dylib Referenced from: /private/var/containers/Bundle/Application/745912AF-A928-465C-B340-872BD1C9F368/example.app/example Reason: image not found dyld: launch, loading dependent libraries DYLD_LIBRARY_PATH=/usr/lib/system/introspection DYLD_INSERT_LIBRARIES=/Developer/usr/lib/libBacktraceRecording.dylib:/Developer/usr/lib/libMainThreadChecker.dylib:/Developer/Library/PrivateFrameworks/DTDDISupport.framework/libViewDebuggerSupport.dylib:/Developer/Library/PrivateFrameworks/GPUTools.framework/libglInterpose.dylib:/usr/lib/libMTLCapture.dylib ``` This can be reproduced by using cargo-mobile to generate a winit example project, and then attempting to run it on an iOS device (`cargo mobile init && cargo apple open`). In our projects that depend on DisplayLink, the build instead fails with a linker error: ``` = note: Undefined symbols for architecture arm64: "_CACurrentMediaTime", referenced from: display_link::ios::run_callback_ios10::hda81197ff46aedbd in libapp-4f0abc1d7684103f.rlib(app-4f0abc1d7684103f.40d4iro0yz1iy487.rcgu.o) display_link::ios::run_callback_pre_ios10::h91f085da19374320 in libapp-4f0abc1d7684103f.rlib(app-4f0abc1d7684103f.40d4iro0yz1iy487.rcgu.o) ld: symbol(s) not found for architecture arm64 ``` After reverting the change to enable dynamic linking on iOS, everything works the same as it did on Rust 1.45.2 for me. In the future, would it be possible for me to be pinged when iOS-related PRs are made? I work for a company that intends on using Rust on iOS in production, so I'd gladly provide testing. cc @aspenluxxxy
Configuration menu - View commit details
-
Copy full SHA for b92f3c8 - Browse repository at this point
Copy the full SHA b92f3c8View commit details -
Rollup merge of #77830 - cjgillot:remacro, r=oli-obk
Simplify query proc-macros The query code generation is split between proc-macros and regular macros in `rustc_middle::ty::query`. This PR removes unused capabilities of the proc-macros, and tend to use regular macros for the logic.
Configuration menu - View commit details
-
Copy full SHA for 0647b99 - Browse repository at this point
Copy the full SHA 0647b99View commit details -
Rollup merge of #78109 - cuviper:exhausted-rangeinc, r=dtolnay
Check for exhaustion in RangeInclusive::contains and slicing When a range has finished iteration, `is_empty` returns true, so it should also be the case that `contains` returns false. Fixes #77941.
Configuration menu - View commit details
-
Copy full SHA for e8dbd9d - Browse repository at this point
Copy the full SHA e8dbd9dView commit details -
Rollup merge of #78198 - tmiasko:assert, r=davidtwco
Simplify assert terminator only if condition evaluates to expected value
Configuration menu - View commit details
-
Copy full SHA for 79afa04 - Browse repository at this point
Copy the full SHA 79afa04View commit details -
Rollup merge of #78249 - lcnr:ct-infer-origin, r=varkor
improve const infer error For type inference we probably have to be careful about subtyping and stuff but considering that subtyping shouldn't be relevant for constants I don't really see a reason why we may not want to reuse the const origin here. r? `@varkor`
Configuration menu - View commit details
-
Copy full SHA for 0ec32ef - Browse repository at this point
Copy the full SHA 0ec32efView commit details -
Rollup merge of #78250 - camelid:document-inline-const, r=spastorino
Document inline-const Part of #76001. r? @spastorino
Configuration menu - View commit details
-
Copy full SHA for 58855f9 - Browse repository at this point
Copy the full SHA 58855f9View commit details -
Rollup merge of #78264 - JohnTitor:macro-test, r=petrochenkov
Add regression test for issue-77475 Closes #77475
Configuration menu - View commit details
-
Copy full SHA for ba91d8e - Browse repository at this point
Copy the full SHA ba91d8eView commit details -
Rollup merge of #78268 - JohnTitor:issue-78262, r=estebank
Do not try to report on closures to avoid ICE Fixes #78262
Configuration menu - View commit details
-
Copy full SHA for 09d589e - Browse repository at this point
Copy the full SHA 09d589eView commit details -
Rollup merge of #78274 - Enet4:patch-1, r=jonas-schievink
Update description of Empty Enum for accuracy An empty enum is similar to the never type `!`, rather than the unit type `()`.
Configuration menu - View commit details
-
Copy full SHA for 411bef6 - Browse repository at this point
Copy the full SHA 411bef6View commit details -
Rollup merge of #78278 - lcnr:predicate-visit, r=matthewjasper
move `visit_predicate` into `TypeVisitor` Seems easier than dealing with `PredicateVisitor` for me which I needed for object safety checks for `PredicateAtom::ConstEvaluatable`. Is there a reason I am missing for this split? r? @matthewjasper
Configuration menu - View commit details
-
Copy full SHA for 49dc5ec - Browse repository at this point
Copy the full SHA 49dc5ecView commit details -
Rollup merge of #78293 - nasso:master, r=GuillaumeGomez
Always store Rustdoc theme when it's changed `switchTheme` (too) lazily updated the value of `rustdoc-theme` in `localStorage`, leading to an incorrect stored value when the system theme is the same as the default (`light`) theme. Fixes #78273
Configuration menu - View commit details
-
Copy full SHA for 9a132f5 - Browse repository at this point
Copy the full SHA 9a132f5View commit details