Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualify panic! as core::panic! in non-built-in core macros #78343

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Qualify panic! as core::panic! in non-built-in core macros #78343

merged 2 commits into from
Nov 24, 2020

Commits on Nov 23, 2020

  1. Qualify panic! as core::panic! in non-built-in core macros 

    Otherwise code like this

    #![no_implicit_prelude]

    fn main() {
        ::std::todo!();
        ::std::unimplemented!();
    }

will fail to compile, which is unfortunate and presumably unintended.

This changes many invocations of `panic!` in a `macro_rules!` definition
to invocations of `$crate::panic!`, which makes the invocations hygienic.

Note that this does not make the built-in macro `assert!` hygienic.
    @camelid
    camelid committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    d37e1e1 View commit details
    Browse the repository at this point in the history

  2. Clean up core macros documentation 

    * Switch a couple links over to intra-doc links
* Clean up some formatting/typography
    @camelid
    camelid committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    d8b1d51 View commit details
    Browse the repository at this point in the history