x.py setup: Create config.toml in the current directory, not the top-level directory #78550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
T-bootstrap
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Oct 30, 2020
|
r=me unless you specifically want to wait for @pnkfelix's review. |
|
@bors r=Mark-Simulacrum I asked pnkfelix to review since I never heard back from them in the original thread, but from their bug report I think this is the behavior they expected. |
|
📌 Commit 8cf7d66 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 31, 2020
x.py setup: Create config.toml in the current directory, not the top-level directory See rust-lang#78509 for discussion. r? @pnkfelix cc @cuviper @Mark-Simulacrum
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Oct 31, 2020
x.py setup: Create config.toml in the current directory, not the top-level directory See rust-lang#78509 for discussion. r? @pnkfelix cc @cuviper @Mark-Simulacrum
This was referenced Oct 31, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#74622 (Add std::panic::panic_any.) - rust-lang#77099 (make exp_m1 and ln_1p examples more representative of use) - rust-lang#78526 (Strip tokens from trait and impl items before printing AST JSON) - rust-lang#78550 (x.py setup: Create config.toml in the current directory, not the top-level directory) - rust-lang#78577 (validator: Extend aliasing check to a call terminator) - rust-lang#78581 (Constantify more BTreeMap and BTreeSet functions) - rust-lang#78587 (parser: Cleanup `LazyTokenStream` and avoid some clones) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #78509 for discussion.
r? @pnkfelix
cc @cuviper @Mark-Simulacrum