Commits on Nov 6, 2020

1. The renumber pass is long gone …

   Originally, there has been a dedicated pass for renumbering
   AST NodeIds to have actual values. This pass had been added by
   commit a5ad4c3.
   
   Then, later, this step was moved to where it resides now,
   macro expansion. See commit c86c8d4
   or PR rust-lang#36438.
   
   The comment snippet, added by the original commit, has
   survived the times without any change, becoming outdated
   at removal of the dedicated pass.
   
   Nowadays, grepping for the next_node_id function will show up
   multiple places in the compiler that call it, but the main
   rewriting that the comment talks about is still done in the
   expansion step, inside an innocious looking visit_id function
   that's called during macro invocation collection.

   

   est31 committed Nov 6, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for dfa5e46
   • Browse repository at this point

   Copy the full SHA

   dfa5e46 View commit details

   Browse the repository at this point in the history