Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying errors when rustbook tests fail. #79064

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Fix displaying errors when rustbook tests fail. #79064

merged 1 commit into from
Nov 15, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 15, 2020

This ensures that output from mdbook is displayed when running the rustbook wrapper. I believe this was a regression as a result of #69115 where it was changed from running rustdoc directly to using rustbook.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2020
@Mark-Simulacrum
Copy link
Member

Seems unfortunate these are only displayed via env logger, but @bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 15, 2020

📌 Commit 5b9e9d0 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2020
@ehuss
Copy link
Contributor Author

ehuss commented Nov 15, 2020

Oh, thinking about it more, I think it was changed by rust-lang/mdBook#1313. I didn't really think about the interactions here.

@Mark-Simulacrum
Copy link
Member

Looks like something should be changed.

@bors
Copy link
Contributor

bors commented Nov 15, 2020

⌛ Testing commit 5b9e9d0 with merge d38281f2effdb6c05659864070df1312dea51763...

@bors
Copy link
Contributor

bors commented Nov 15, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2020
@ehuss
Copy link
Contributor Author

ehuss commented Nov 15, 2020

@bors retry
#78665

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2020
@bors
Copy link
Contributor

bors commented Nov 15, 2020

⌛ Testing commit 5b9e9d0 with merge 603ab5b...

@bors
Copy link
Contributor

bors commented Nov 15, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 603ab5b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2020
@bors bors merged commit 603ab5b into rust-lang:master Nov 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 15, 2020
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @rustbot