Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #79065

Merged
merged 52 commits into from
Nov 15, 2020
Merged

Rollup of 15 pull requests #79065

merged 52 commits into from
Nov 15, 2020

Commits on Oct 25, 2020

  1. Configuration menu
    Copy the full SHA
    3dd0a7d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2020

  1. Configuration menu
    Copy the full SHA
    459dae9 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. address reviewer comments

    mark-i-m committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    43e4783 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Configuration menu
    Copy the full SHA
    659aa77 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    f5e67b5 View commit details
    Browse the repository at this point in the history
  2. Ignore tidy linelength

    poliorcetics committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9c70696 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd0eb07 View commit details
    Browse the repository at this point in the history
  4. Use intradoc-links for the whole test, add a @Has check

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    poliorcetics and Joshua Nelson committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    ecfeac5 View commit details
    Browse the repository at this point in the history
  5. Include llvm-as in llvm-tools-preview component

    Including llvm-as adds the ability to include assembly language fragments
    that can be inlined using LTO.
    zec committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    562d50e View commit details
    Browse the repository at this point in the history
  6. Merge changes from rust-lang/rust

    zec committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    e4a43fc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    38fa66a View commit details
    Browse the repository at this point in the history
  8. Overcome Sync issues with non-parallel compiler

    Per Mark's recommendation at:
    rust-lang#78963 (comment)
    richkadel committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    eb9f2bb View commit details
    Browse the repository at this point in the history
  9. fix pretty print for qpath

    gui1117 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    775f1e5 View commit details
    Browse the repository at this point in the history
  10. Bumped minimal tested LLVM version to 9

    This bumps the minimal tested llvm version to 9.
    This should enable supporting newer LLVM features (and CPU extensions).
    DevJPM committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    f8a32e9 View commit details
    Browse the repository at this point in the history
  11. explicitly add llvm-9-dev in dockerfile

    apparently llvm-8-tools already had llvm-8-dev as a dependency
    which was removed in llvm-9-tools, so we need to explicitly pull
    llvm-9-dev to make a build
    DevJPM committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6323565 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6830f1c View commit details
    Browse the repository at this point in the history
  13. fully exploited the dropped support of LLVM 8

    This commit grepped for LLVM_VERSION_GE, LLVM_VERSION_LT, get_major_version and
    min-llvm-version and statically evaluated every expression possible
    (and sensible) assuming that the LLVM version is >=9 now
    DevJPM committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    b51bcc7 View commit details
    Browse the repository at this point in the history
  14. Removed an unused function now that LLVM 9 is the minimal supported v…

    …ersion
    
    The function was only used in LLVM 8 compatibility code
    and was found and flagged by dead code detection and now removed.
    DevJPM committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    8236830 View commit details
    Browse the repository at this point in the history
  15. Dropped Support for Bidirectional Custom Target Definition Emulation

    as requested in the review and argued that this is only consistent with later LLVM upgrades
    DevJPM committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7e443c4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    86193ca View commit details
    Browse the repository at this point in the history
  17. Avoid installing external LLVM dylibs

    If the LLVM was externally provided, then we don't currently copy artifacts into
    the sysroot. This is not necessarily the right choice (in particular, it will
    require the LLVM dylib to be in the linker's load path at runtime), but the
    common use case for external LLVMs is distribution provided LLVMs, and in that
    case they're usually in the standard search path (e.g., /usr/lib) and copying
    them here is going to cause problems as we may end up with the wrong files and
    isn't what distributions want.
    
    This behavior may be revisited in the future though.
    Mark-Simulacrum committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    3747df7 View commit details
    Browse the repository at this point in the history
  18. Fix an intrinsic invocation on threaded wasm

    This looks like it was forgotten to get updated in rust-lang#74482 and wasm with
    threads isn't built on CI so we didn't catch this by accident.
    alexcrichton committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    010265a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    dd682cb View commit details
    Browse the repository at this point in the history
  20. Never inline when no_sanitize attributes differ

    The inliner looks if a sanitizer is enabled before considering
    `no_sanitize` attribute as possible source of incompatibility.
    
    The MIR inlining could happen in a crate with sanitizer disabled, but
    code generation in a crate with sanitizer enabled, thus the attribute
    would be incorrectly ignored.
    
    To avoid the issue never inline functions with different `no_sanitize`
    attributes.
    tmiasko committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    0b4af16 View commit details
    Browse the repository at this point in the history
  21. Never inline cold functions

    The information about cold attribute is lost during inlining,
    Avoid the issue by never inlining cold functions.
    tmiasko committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    ae43326 View commit details
    Browse the repository at this point in the history
  22. Remove check for impossible condition

    The callee body is already transformed; the condition is always false.
    tmiasko committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9bb3d6b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    66cadec View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    79d853e View commit details
    Browse the repository at this point in the history
  25. ./x.py test --bless

    tmiasko committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2a010dd View commit details
    Browse the repository at this point in the history
  26. Normalize function type during validation

    During inlining, the callee body is normalized and has types revealed,
    but some of locals corresponding to the arguments might come from the
    caller body which is not. As a result the caller body does not pass
    validation without additional normalization.
    tmiasko committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    d486bfc View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    99be78d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Added a unit test for BcbCounters

    Restructured the code a little, to allow getting both the mir::Body and
    coverage graph.
    richkadel committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c131063 View commit details
    Browse the repository at this point in the history
  2. Clean up outdated use_once_payload pretty printer comment

    While reading some parts of the pretty printer code, I noticed this old comment
    which seemed out of place. The `use_once_payload` this outdated comment mentions
    was removed in 2017 in 40f03a1, so this
    completes the work by removing the comment.
    jryans committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    bd0fba2 View commit details
    Browse the repository at this point in the history
  3. Fix wrong XPath

    poliorcetics committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    309d863 View commit details
    Browse the repository at this point in the history
  4. Addressed feedback

    richkadel committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    b4b0ef3 View commit details
    Browse the repository at this point in the history
  5. refactor: vec_deque ignore-tidy-filelength

    commit c547d5fabcd756515afa7263ee5304965bb4c497
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 11:22:23 2020 +0000
    
        test: updating ui/hygiene/panic-location.rs expected
    
    commit 2af03769c4ffdbbbad75197a1ad0df8c599186be
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 10:43:30 2020 +0000
    
        fix: documentation unresolved link
    
    commit c4b0df361ce27d7392d8016229f2e0265af32086
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:58:31 2020 +0000
    
        style: compiling with Rust's style guidelines
    
    commit bdd2de5f3c09b49a18e3293f2457fcab25557c96
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:56:31 2020 +0000
    
        refactor: removing ignore-tidy-filelength
    
    commit fcc4b3bc41f57244c65ebb8e4efe4cbc9460b5a9
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:51:35 2020 +0000
    
        refactor: moving trait RingSlices to ring_slices.rs
    
    commit 2f0cc539c06d8841baf7f675168f68ca7c21e68e
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:46:09 2020 +0000
    
        refactor: moving struct PairSlices to pair_slices.rs
    
    commit a55d3ef1dab4c3d85962b3a601ff8d1f7497faf2
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:31:45 2020 +0000
    
        refactor: moving struct Iter to iter.rs
    
    commit 76ab33a12442a03726f36f606b4e0fe70f8f246b
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:24:32 2020 +0000
    
        refactor: moving struct IntoIter into into_iter.rs
    
    commit abe0d9eea2933881858c3b1bc09df67cedc5ada5
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 02:19:07 2020 +0000
    
        refactor: moving struct IterMut into iter_mut.rs
    
    commit 70ebd6420335e1895e2afa2763a0148897963e24
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 01:49:15 2020 +0000
    
        refactor: moved macros into macros.rs
    
    commit b08dd2add994b04ae851aa065800bd8bd6326134
    Author: C <DeveloperC@protonmail.com>
    Date:   Sat Oct 31 01:05:36 2020 +0000
    
        refactor: moving vec_deque.rs to vec_deque/mod.rs
    DeveloperC286 committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    75dfc71 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. Style nit

    Co-authored-by: matthewjasper <20113453+matthewjasper@users.noreply.github.com>
    mark-i-m and matthewjasper committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    b825ae7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2020

  1. Rollup merge of rust-lang#78352 - JohnTitor:issue-75229, r=Dylan-DPC

    Do not call `unwrap` with `signatures` option enabled
    
    Fixes rust-lang#75229
    Didn't add a test since I couldn't set `RUST_SAVE_ANALYSIS_CONFIG` even with `rustc-env`.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    dc4d655 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#78590 - DeveloperC286:issue_60302, r=varkor

    refactor: removing alloc::collections::vec_deque ignore-tidy-filelength
    
    This PR removes the need for ignore-tidy-filelength for alloc::collections::vec_deque which is part of the issue rust-lang#60302
    
    It is probably easiest to review this PR by looking at it commit by commit rather than looking at the overall diff.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    dbb37fb View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#78848 - DevJPM:ci-llvm-9, r=nikic

    Bump minimal supported LLVM version to 9
    
    This bumps the minimal tested llvm version to 9.
    This should enable supporting newer LLVM features (and CPU extensions).
    
    This was motived by rust-lang#78361 having to drop features because of LLVM 8 not supporting certain CPU extensions yet.
    This was declared relatively uncontroversial on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Min.20Supported.20LLVM.20Upgrade.20Process.3F/near/215957859).
    
    Paging ````@eddyb```` because there was a comment in the [dockerfile](https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/x86_64-gnu-llvm-8/Dockerfile#L42) describing a hack (which I don't quite understand) which was also blocked by not having LLVM 9.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    ae7020f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#78856 - mark-i-m:fix-or-pat-ice, r=matthewj…

    …asper
    
    Explicitly checking for or-pattern before test
    
    Fixes rust-lang#72680
    
    cc rust-lang#54883
    
    r? ````@varkor````
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    a29b68f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#78948 - slanterns:master, r=varkor

    test: add `()=()=()=...` to weird-exprs.rs
    
    Idea from rust-lang#71156 (comment) 😄
    
    Builds on nightly since rust-lang#78748 has been merged.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    7f7fa97 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#78962 - poliorcetics:rustdoc-raw-ident-test…

    …, r=jyn514
    
    Add a test for r# identifiers
    
    I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :)
    
    ```````@rustbot``````` modify labels: T-rustdoc
    
    r? ```````@jyn514```````
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    5060389 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#78963 - richkadel:llvm-coverage-counters-2.…

    …0.4, r=tmandry
    
    Added some unit tests as requested
    
    As discussed in PR rust-lang#78267, for example:
    
    * rust-lang#78267 (comment)
    * rust-lang#78267 (comment)
    
    r? ```````@tmandry```````
    FYI: ```````@wesleywiser```````
    
    This is pretty much self contained, but depending on feedback and timing, I may have a chance to add a few more unit tests requested against `counters.rs`. I'm looking at those now.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    335a255 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk

    Never inline C variadics, cold functions, functions with incompatible attributes ...
    
    ... and fix generator inlining.
    
    Closes rust-lang#67863.
    Closes rust-lang#78859.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    6be44ed View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#78968 - zec:add-llvm-as, r=Mark-Simulacrum

    Include llvm-as in llvm-tools-preview component
    
    Including `llvm-as` adds the ability to include assembly language fragments that can be inlined using LTO while making sure the correct version of LLVM is always used.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    3fe2aba View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#78969 - tmiasko:normalize, r=davidtwco

    Normalize function type during validation
    
    During inlining, the callee body is normalized and has types revealed,
    but some of locals corresponding to the arguments might come from the
    caller body which is not. As a result the caller body does not pass
    validation without additional normalization.
    
    Closes rust-lang#78442.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    7e0441d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#78980 - thiolliere:gui-fix-qpath, r=estebank

    Fix rustc_ast_pretty print_qpath resulting in invalid macro input
    
    related rust-lang#76874 (third case)
    
    ### Issue:
    
    The input for a procedural macro is incorrect, for the rust code:
    ```rust
    
    mod m {
        pub trait Tr {
            type Ts: super::Tu;
        }
    }
    
    trait Tu {
        fn dummy() { }
    }
    
    #[may_proc_macro]
    fn foo() {
        <T as m::Tr>::Ts::dummy();
    }
    ```
    the macro will get the input:
    ```rust
    fn foo() {
        <T as m::Tr>::dummy();
    }
    ```
    Thus `Ts` has disappeared.
    
    ### Fix:
    
    This is due to invalid pretty print of qpath. This PR fix it.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    4fcb617 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#78986 - Mark-Simulacrum:fix-llvm, r=alexcri…

    …chton
    
    Avoid installing external LLVM dylibs
    
    If the LLVM was externally provided, then we don't currently copy artifacts into
    the sysroot. This is not necessarily the right choice (in particular, it will
    require the LLVM dylib to be in the linker's load path at runtime), but the
    common use case for external LLVMs is distribution provided LLVMs, and in that
    case they're usually in the standard search path (e.g., /usr/lib) and copying
    them here is going to cause problems as we may end up with the wrong files and
    isn't what distributions want.
    
    This behavior may be revisited in the future though.
    
    Fixes rust-lang#78932.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    e3d52b8 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#78988 - alexcrichton:one-more-intrinsic, r=…

    …sfackler
    
    Fix an intrinsic invocation on threaded wasm
    
    This looks like it was forgotten to get updated in rust-lang#74482 and wasm with
    threads isn't built on CI so we didn't catch this by accident.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    d57212d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#78993 - petrochenkov:specdash, r=oli-obk

    rustc_target: Fix dash vs underscore mismatches in option names
    
    Fixes rust-lang#78981 (regression from rust-lang#78875, the old option names used dashes)
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    96fc0f4 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#79013 - jryans:cleanup-use-once-pretty-comm…

    …ent, r=Mark-Simulacrum
    
    Clean up outdated `use_once_payload` pretty printer comment
    
    While reading some parts of the pretty printer code, I noticed this old comment
    which seemed out of place. The `use_once_payload` this outdated comment mentions
    was removed in 2017 in 40f03a1, so this
    completes the work by removing the comment.
    Dylan-DPC committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    96515cc View commit details
    Browse the repository at this point in the history