-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #79065
Rollup of 15 pull requests #79065
Commits on Oct 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3dd0a7d - Browse repository at this point
Copy the full SHA 3dd0a7dView commit details
Commits on Nov 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 459dae9 - Browse repository at this point
Copy the full SHA 459dae9View commit details
Commits on Nov 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 43e4783 - Browse repository at this point
Copy the full SHA 43e4783View commit details
Commits on Nov 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 659aa77 - Browse repository at this point
Copy the full SHA 659aa77View commit details
Commits on Nov 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f5e67b5 - Browse repository at this point
Copy the full SHA f5e67b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c70696 - Browse repository at this point
Copy the full SHA 9c70696View commit details -
Added some unit tests as requested
As discussed in PR rust-lang#78267, for example: * rust-lang#78267 (comment) * rust-lang#78267 (comment)
Configuration menu - View commit details
-
Copy full SHA for bd0eb07 - Browse repository at this point
Copy the full SHA bd0eb07View commit details -
Use intradoc-links for the whole test, add a @Has check
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for ecfeac5 - Browse repository at this point
Copy the full SHA ecfeac5View commit details -
Include llvm-as in llvm-tools-preview component
Including llvm-as adds the ability to include assembly language fragments that can be inlined using LTO.
Configuration menu - View commit details
-
Copy full SHA for 562d50e - Browse repository at this point
Copy the full SHA 562d50eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4a43fc - Browse repository at this point
Copy the full SHA e4a43fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38fa66a - Browse repository at this point
Copy the full SHA 38fa66aView commit details -
Overcome Sync issues with non-parallel compiler
Per Mark's recommendation at: rust-lang#78963 (comment)
Configuration menu - View commit details
-
Copy full SHA for eb9f2bb - Browse repository at this point
Copy the full SHA eb9f2bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 775f1e5 - Browse repository at this point
Copy the full SHA 775f1e5View commit details -
Bumped minimal tested LLVM version to 9
This bumps the minimal tested llvm version to 9. This should enable supporting newer LLVM features (and CPU extensions).
Configuration menu - View commit details
-
Copy full SHA for f8a32e9 - Browse repository at this point
Copy the full SHA f8a32e9View commit details -
explicitly add llvm-9-dev in dockerfile
apparently llvm-8-tools already had llvm-8-dev as a dependency which was removed in llvm-9-tools, so we need to explicitly pull llvm-9-dev to make a build
Configuration menu - View commit details
-
Copy full SHA for 6323565 - Browse repository at this point
Copy the full SHA 6323565View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6830f1c - Browse repository at this point
Copy the full SHA 6830f1cView commit details -
fully exploited the dropped support of LLVM 8
This commit grepped for LLVM_VERSION_GE, LLVM_VERSION_LT, get_major_version and min-llvm-version and statically evaluated every expression possible (and sensible) assuming that the LLVM version is >=9 now
Configuration menu - View commit details
-
Copy full SHA for b51bcc7 - Browse repository at this point
Copy the full SHA b51bcc7View commit details -
Removed an unused function now that LLVM 9 is the minimal supported v…
…ersion The function was only used in LLVM 8 compatibility code and was found and flagged by dead code detection and now removed.
Configuration menu - View commit details
-
Copy full SHA for 8236830 - Browse repository at this point
Copy the full SHA 8236830View commit details -
Dropped Support for Bidirectional Custom Target Definition Emulation
as requested in the review and argued that this is only consistent with later LLVM upgrades
Configuration menu - View commit details
-
Copy full SHA for 7e443c4 - Browse repository at this point
Copy the full SHA 7e443c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86193ca - Browse repository at this point
Copy the full SHA 86193caView commit details -
Avoid installing external LLVM dylibs
If the LLVM was externally provided, then we don't currently copy artifacts into the sysroot. This is not necessarily the right choice (in particular, it will require the LLVM dylib to be in the linker's load path at runtime), but the common use case for external LLVMs is distribution provided LLVMs, and in that case they're usually in the standard search path (e.g., /usr/lib) and copying them here is going to cause problems as we may end up with the wrong files and isn't what distributions want. This behavior may be revisited in the future though.
Configuration menu - View commit details
-
Copy full SHA for 3747df7 - Browse repository at this point
Copy the full SHA 3747df7View commit details -
Fix an intrinsic invocation on threaded wasm
This looks like it was forgotten to get updated in rust-lang#74482 and wasm with threads isn't built on CI so we didn't catch this by accident.
Configuration menu - View commit details
-
Copy full SHA for 010265a - Browse repository at this point
Copy the full SHA 010265aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd682cb - Browse repository at this point
Copy the full SHA dd682cbView commit details -
Never inline when
no_sanitize
attributes differThe inliner looks if a sanitizer is enabled before considering `no_sanitize` attribute as possible source of incompatibility. The MIR inlining could happen in a crate with sanitizer disabled, but code generation in a crate with sanitizer enabled, thus the attribute would be incorrectly ignored. To avoid the issue never inline functions with different `no_sanitize` attributes.
Configuration menu - View commit details
-
Copy full SHA for 0b4af16 - Browse repository at this point
Copy the full SHA 0b4af16View commit details -
The information about cold attribute is lost during inlining, Avoid the issue by never inlining cold functions.
Configuration menu - View commit details
-
Copy full SHA for ae43326 - Browse repository at this point
Copy the full SHA ae43326View commit details -
Remove check for impossible condition
The callee body is already transformed; the condition is always false.
Configuration menu - View commit details
-
Copy full SHA for 9bb3d6b - Browse repository at this point
Copy the full SHA 9bb3d6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66cadec - Browse repository at this point
Copy the full SHA 66cadecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79d853e - Browse repository at this point
Copy the full SHA 79d853eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a010dd - Browse repository at this point
Copy the full SHA 2a010ddView commit details -
Normalize function type during validation
During inlining, the callee body is normalized and has types revealed, but some of locals corresponding to the arguments might come from the caller body which is not. As a result the caller body does not pass validation without additional normalization.
Configuration menu - View commit details
-
Copy full SHA for d486bfc - Browse repository at this point
Copy the full SHA d486bfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99be78d - Browse repository at this point
Copy the full SHA 99be78dView commit details
Commits on Nov 13, 2020
-
Added a unit test for BcbCounters
Restructured the code a little, to allow getting both the mir::Body and coverage graph.
Configuration menu - View commit details
-
Copy full SHA for c131063 - Browse repository at this point
Copy the full SHA c131063View commit details -
Clean up outdated
use_once_payload
pretty printer commentWhile reading some parts of the pretty printer code, I noticed this old comment which seemed out of place. The `use_once_payload` this outdated comment mentions was removed in 2017 in 40f03a1, so this completes the work by removing the comment.
Configuration menu - View commit details
-
Copy full SHA for bd0fba2 - Browse repository at this point
Copy the full SHA bd0fba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 309d863 - Browse repository at this point
Copy the full SHA 309d863View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4b0ef3 - Browse repository at this point
Copy the full SHA b4b0ef3View commit details -
refactor: vec_deque ignore-tidy-filelength
commit c547d5fabcd756515afa7263ee5304965bb4c497 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 11:22:23 2020 +0000 test: updating ui/hygiene/panic-location.rs expected commit 2af03769c4ffdbbbad75197a1ad0df8c599186be Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 10:43:30 2020 +0000 fix: documentation unresolved link commit c4b0df361ce27d7392d8016229f2e0265af32086 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:58:31 2020 +0000 style: compiling with Rust's style guidelines commit bdd2de5f3c09b49a18e3293f2457fcab25557c96 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:56:31 2020 +0000 refactor: removing ignore-tidy-filelength commit fcc4b3bc41f57244c65ebb8e4efe4cbc9460b5a9 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:51:35 2020 +0000 refactor: moving trait RingSlices to ring_slices.rs commit 2f0cc539c06d8841baf7f675168f68ca7c21e68e Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:46:09 2020 +0000 refactor: moving struct PairSlices to pair_slices.rs commit a55d3ef1dab4c3d85962b3a601ff8d1f7497faf2 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:31:45 2020 +0000 refactor: moving struct Iter to iter.rs commit 76ab33a12442a03726f36f606b4e0fe70f8f246b Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:24:32 2020 +0000 refactor: moving struct IntoIter into into_iter.rs commit abe0d9eea2933881858c3b1bc09df67cedc5ada5 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 02:19:07 2020 +0000 refactor: moving struct IterMut into iter_mut.rs commit 70ebd6420335e1895e2afa2763a0148897963e24 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 01:49:15 2020 +0000 refactor: moved macros into macros.rs commit b08dd2add994b04ae851aa065800bd8bd6326134 Author: C <DeveloperC@protonmail.com> Date: Sat Oct 31 01:05:36 2020 +0000 refactor: moving vec_deque.rs to vec_deque/mod.rs
Configuration menu - View commit details
-
Copy full SHA for 75dfc71 - Browse repository at this point
Copy the full SHA 75dfc71View commit details
Commits on Nov 14, 2020
-
Co-authored-by: matthewjasper <20113453+matthewjasper@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b825ae7 - Browse repository at this point
Copy the full SHA b825ae7View commit details
Commits on Nov 15, 2020
-
Rollup merge of rust-lang#78352 - JohnTitor:issue-75229, r=Dylan-DPC
Do not call `unwrap` with `signatures` option enabled Fixes rust-lang#75229 Didn't add a test since I couldn't set `RUST_SAVE_ANALYSIS_CONFIG` even with `rustc-env`.
Configuration menu - View commit details
-
Copy full SHA for dc4d655 - Browse repository at this point
Copy the full SHA dc4d655View commit details -
Rollup merge of rust-lang#78590 - DeveloperC286:issue_60302, r=varkor
refactor: removing alloc::collections::vec_deque ignore-tidy-filelength This PR removes the need for ignore-tidy-filelength for alloc::collections::vec_deque which is part of the issue rust-lang#60302 It is probably easiest to review this PR by looking at it commit by commit rather than looking at the overall diff.
Configuration menu - View commit details
-
Copy full SHA for dbb37fb - Browse repository at this point
Copy the full SHA dbb37fbView commit details -
Rollup merge of rust-lang#78848 - DevJPM:ci-llvm-9, r=nikic
Bump minimal supported LLVM version to 9 This bumps the minimal tested llvm version to 9. This should enable supporting newer LLVM features (and CPU extensions). This was motived by rust-lang#78361 having to drop features because of LLVM 8 not supporting certain CPU extensions yet. This was declared relatively uncontroversial on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Min.20Supported.20LLVM.20Upgrade.20Process.3F/near/215957859). Paging ````@eddyb```` because there was a comment in the [dockerfile](https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/x86_64-gnu-llvm-8/Dockerfile#L42) describing a hack (which I don't quite understand) which was also blocked by not having LLVM 9.
Configuration menu - View commit details
-
Copy full SHA for ae7020f - Browse repository at this point
Copy the full SHA ae7020fView commit details -
Rollup merge of rust-lang#78856 - mark-i-m:fix-or-pat-ice, r=matthewj…
…asper Explicitly checking for or-pattern before test Fixes rust-lang#72680 cc rust-lang#54883 r? ````@varkor````
Configuration menu - View commit details
-
Copy full SHA for a29b68f - Browse repository at this point
Copy the full SHA a29b68fView commit details -
Rollup merge of rust-lang#78948 - slanterns:master, r=varkor
test: add `()=()=()=...` to weird-exprs.rs Idea from rust-lang#71156 (comment) 😄 Builds on nightly since rust-lang#78748 has been merged.
Configuration menu - View commit details
-
Copy full SHA for 7f7fa97 - Browse repository at this point
Copy the full SHA 7f7fa97View commit details -
Rollup merge of rust-lang#78962 - poliorcetics:rustdoc-raw-ident-test…
…, r=jyn514 Add a test for r# identifiers I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :) ```````@rustbot``````` modify labels: T-rustdoc r? ```````@jyn514```````
Configuration menu - View commit details
-
Copy full SHA for 5060389 - Browse repository at this point
Copy the full SHA 5060389View commit details -
Rollup merge of rust-lang#78963 - richkadel:llvm-coverage-counters-2.…
…0.4, r=tmandry Added some unit tests as requested As discussed in PR rust-lang#78267, for example: * rust-lang#78267 (comment) * rust-lang#78267 (comment) r? ```````@tmandry``````` FYI: ```````@wesleywiser``````` This is pretty much self contained, but depending on feedback and timing, I may have a chance to add a few more unit tests requested against `counters.rs`. I'm looking at those now.
Configuration menu - View commit details
-
Copy full SHA for 335a255 - Browse repository at this point
Copy the full SHA 335a255View commit details -
Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk
Never inline C variadics, cold functions, functions with incompatible attributes ... ... and fix generator inlining. Closes rust-lang#67863. Closes rust-lang#78859.
Configuration menu - View commit details
-
Copy full SHA for 6be44ed - Browse repository at this point
Copy the full SHA 6be44edView commit details -
Rollup merge of rust-lang#78968 - zec:add-llvm-as, r=Mark-Simulacrum
Include llvm-as in llvm-tools-preview component Including `llvm-as` adds the ability to include assembly language fragments that can be inlined using LTO while making sure the correct version of LLVM is always used.
Configuration menu - View commit details
-
Copy full SHA for 3fe2aba - Browse repository at this point
Copy the full SHA 3fe2abaView commit details -
Rollup merge of rust-lang#78969 - tmiasko:normalize, r=davidtwco
Normalize function type during validation During inlining, the callee body is normalized and has types revealed, but some of locals corresponding to the arguments might come from the caller body which is not. As a result the caller body does not pass validation without additional normalization. Closes rust-lang#78442.
Configuration menu - View commit details
-
Copy full SHA for 7e0441d - Browse repository at this point
Copy the full SHA 7e0441dView commit details -
Rollup merge of rust-lang#78980 - thiolliere:gui-fix-qpath, r=estebank
Fix rustc_ast_pretty print_qpath resulting in invalid macro input related rust-lang#76874 (third case) ### Issue: The input for a procedural macro is incorrect, for the rust code: ```rust mod m { pub trait Tr { type Ts: super::Tu; } } trait Tu { fn dummy() { } } #[may_proc_macro] fn foo() { <T as m::Tr>::Ts::dummy(); } ``` the macro will get the input: ```rust fn foo() { <T as m::Tr>::dummy(); } ``` Thus `Ts` has disappeared. ### Fix: This is due to invalid pretty print of qpath. This PR fix it.
Configuration menu - View commit details
-
Copy full SHA for 4fcb617 - Browse repository at this point
Copy the full SHA 4fcb617View commit details -
Rollup merge of rust-lang#78986 - Mark-Simulacrum:fix-llvm, r=alexcri…
…chton Avoid installing external LLVM dylibs If the LLVM was externally provided, then we don't currently copy artifacts into the sysroot. This is not necessarily the right choice (in particular, it will require the LLVM dylib to be in the linker's load path at runtime), but the common use case for external LLVMs is distribution provided LLVMs, and in that case they're usually in the standard search path (e.g., /usr/lib) and copying them here is going to cause problems as we may end up with the wrong files and isn't what distributions want. This behavior may be revisited in the future though. Fixes rust-lang#78932.
Configuration menu - View commit details
-
Copy full SHA for e3d52b8 - Browse repository at this point
Copy the full SHA e3d52b8View commit details -
Rollup merge of rust-lang#78988 - alexcrichton:one-more-intrinsic, r=…
…sfackler Fix an intrinsic invocation on threaded wasm This looks like it was forgotten to get updated in rust-lang#74482 and wasm with threads isn't built on CI so we didn't catch this by accident.
Configuration menu - View commit details
-
Copy full SHA for d57212d - Browse repository at this point
Copy the full SHA d57212dView commit details -
Rollup merge of rust-lang#78993 - petrochenkov:specdash, r=oli-obk
rustc_target: Fix dash vs underscore mismatches in option names Fixes rust-lang#78981 (regression from rust-lang#78875, the old option names used dashes)
Configuration menu - View commit details
-
Copy full SHA for 96fc0f4 - Browse repository at this point
Copy the full SHA 96fc0f4View commit details -
Rollup merge of rust-lang#79013 - jryans:cleanup-use-once-pretty-comm…
…ent, r=Mark-Simulacrum Clean up outdated `use_once_payload` pretty printer comment While reading some parts of the pretty printer code, I noticed this old comment which seemed out of place. The `use_once_payload` this outdated comment mentions was removed in 2017 in 40f03a1, so this completes the work by removing the comment.
Configuration menu - View commit details
-
Copy full SHA for 96515cc - Browse repository at this point
Copy the full SHA 96515ccView commit details