Remove Hacks and Fixmes from PR CI's LLVM-9 Container #79068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikic
reviewed
Nov 15, 2020
| python2.7 ../x.py --stage 2 test src/test/mir-opt --pass=build \ | ||
| --host='' --target=armv5te-unknown-linux-gnueabi && \ | ||
| python2.7 ../x.py --stage 2 test src/test/mir-opt \ | ||
| --host='' --target=i686-unknown-linux-gnueabi && \ |
There was a problem hiding this comment.
The target is called i686-unknown-linux-gnu (without the eabi, that's an ARM specific thing).
There was a problem hiding this comment.
Yes, I was a bit over-eager with the copy and paste there, it's fixed now (though with a force-push instead of a commit because I didn't see your review in time, sorry)
Now with LLVM 9 being the minimum supported version, we can finally remove the hacks in the dockerfile. This wasn't in the main PR bumping the version as I didn't quite understand what's going on and needed here.
DevJPM
force-pushed
the
ci-llvm-9-fix
branch
from
cb5abb7
to
a015c21
Compare
It seems that by default the 32-bit headers are not actually installed when installing development tooling. As we're using gcc headers, we need to install them as an extra package. See for reference: - https://stackoverflow.com/a/54082790 - https://askubuntu.com/a/106092 Also removed the now unused arm tooling
jyn514
added
A-LLVM
|
@bors r+ rollup=iffy Thanks! |
|
📌 Commit b8f682b has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with LLVM 9 being the minimum supported version (thanks to #78848 ), we can
finally remove the hacks in the dockerfile.
This wasn't in the main PR bumping the version as I didn't quite
understand what's going on and needed here.
Relevant issues and PRs:
EMIT_MIR_FOR_EACH_BIT_WIDTH). #70989I hope I actually adressed things correctly here?