-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] next #79075
[beta] next #79075
Conversation
If the LLVM was externally provided, then we don't currently copy artifacts into the sysroot. This is not necessarily the right choice (in particular, it will require the LLVM dylib to be in the linker's load path at runtime), but the common use case for external LLVMs is distribution provided LLVMs, and in that case they're usually in the standard search path (e.g., /usr/lib) and copying them here is going to cause problems as we may end up with the wrong files and isn't what distributions want. This behavior may be revisited in the future though.
…n one more case"" This reverts commit b20bce8. It retains the test added in that commit as a check-pass test, intended to prevent future (unintentional) regressions.
Should hopefully fix rust-lang#78341 and rust-lang#78340.
|
cc @Xanewok @calebcartwright the submodule bump of RLS and rustfmt didn't merge cleanly; this PR sets RLS to rust-lang/rls@dab1468 which is the same as that PR bumped to but the "from" on that is different. I'm not sure if that's correct, please let me know if not ASAP (we expect to build artifacts tomorrow). |
This allows ControlFlow<BreakType> which is much more ergonomic for common iterator combinator use cases.
…tex. It was used for marker::Send, but Send is already in scope.
The code before this change misused the ReentrantMutexes, by calling init() on them and moving them afterwards. Now that ReentrantMutex requires Pin for init(), this mistake is no longer easy to make.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-authored-by: Peter Todd <pete@petertodd.org>
Co-authored-by: David Tolnay <dtolnay@gmail.com>
RunCompiler::new takes non-optional params, and optional params can be set using set_*field_name* method. finally `run` will forward all fields to `run_compiler`.
Yep, looks like tests are passing here now so I will @bors r+ rollup=never p=1 Will also go back through the listed PRs and bump milestones and set labels as appropriate. |
📌 Commit d9beaaf has been approved by |
⌛ Testing commit d9beaaf with merge 63dddf28d104c094812e51617b00cccc25ae04a4... |
💔 Test failed - checks-actions |
May need #77837 too? |
Miri isn't distributed on beta/stable so we shouldn't need a bump. I've pushed a commit patching over the problem (hopefully) on this branch, will take a closer look over the next cycle hopefully. @bors r+ |
📌 Commit 0b6785f has been approved by |
☀️ Test successful - checks-actions |
This backports:
For RLS/rustfmt compilation to succeed:
ControlFlow::is_{break,continue}
methods #78200As a dependency of #77801: