-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of clean::{Method, TyMethod}
#79125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the same as clean::Function.
Replace it instead with `(clean::Function, Option<hir::Defaultness>)`.
jyn514
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Nov 17, 2020
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 17, 2020
Here's why I needed it for doctree:
Don't ask me why I need to match both of these in the same pattern, without this #78082 ICEs. UPDATE: It turns out this is because doctree was throwing away item names? rust/src/librustdoc/formats/renderer.rs Lines 99 to 100 in 9b2b02a
|
GuillaumeGomez
approved these changes
Nov 17, 2020
Nice, thanks! @bors: r+ |
📌 Commit 2a991e1 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 17, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74293 (Rustdoc test compiler output color) - rust-lang#78702 ([self-profiling] Include the estimated size of each cgu in the profile) - rust-lang#79069 (Get rid of `highlight::Class::None`) - rust-lang#79072 (Fix exhaustiveness in case a byte string literal is used at slice type) - rust-lang#79120 (update rustfmt to v1.4.27) - rust-lang#79125 (Get rid of clean::{Method, TyMethod}) - rust-lang#79126 (Remove duplicate `Trait::auto` field) - rust-lang#79130 (extend macro braces test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 tasks
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Dec 1, 2020
…illaumeGomez Rustdoc: JSON backend experimental impl, with new tests. Based on rust-lang#75114 by `@P1n3appl3` The first commit is all of rust-lang#75114, but squased to 1 commit, as that was much easier to rebase onto master. The git history is a mess, but I think I'll edit it after review, so it's obvious whats new. ## Still to do - [ ] Update docs. - [ ] Add bless option to tests. - [ ] Add test option for multiple files in same crate. - [ ] Decide if the tests should check for json to be equal or subset. - [ ] Go through the rest of the review for the original pr. (This is open because the test system is done(ish), but stuff like [not using a hashmap](rust-lang#75114 (comment)) and [using `CRATE_DEF_INDEX` ](rust-lang#75114 (comment)) hasn't) I'm also sure how many of these we need to do before landing on nightly, as it would be nice to get this in tree, so it isn't effected by churn like rust-lang#79125, rust-lang#79041, rust-lang#79061 r? `@jyn514`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2020
Rustdoc: JSON backend experimental impl, with new tests. Based on rust-lang#75114 by `@P1n3appl3` The first commit is all of rust-lang#75114, but squased to 1 commit, as that was much easier to rebase onto master. The git history is a mess, but I think I'll edit it after review, so it's obvious whats new. ## Still to do - [ ] Update docs. - [ ] Add bless option to tests. - [ ] Add test option for multiple files in same crate. - [ ] Decide if the tests should check for json to be equal or subset. - [ ] Go through the rest of the review for the original pr. (This is open because the test system is done(ish), but stuff like [not using a hashmap](rust-lang#75114 (comment)) and [using `CRATE_DEF_INDEX` ](rust-lang#75114 (comment)) hasn't) I'm also sure how many of these we need to do before landing on nightly, as it would be nice to get this in tree, so it isn't effected by churn like rust-lang#79125, rust-lang#79041, rust-lang#79061 r? `@jyn514`
jyn514
changed the title
Get rid of clean::{Method, TyMethod}
Get rid of Jan 14, 2021
clean::{Method, TyMethod}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're redundant and almost the same as
clean::Function
.I needed this for #78082, although I forget why.
r? @GuillaumeGomez