Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that #[naked] is applied to a function definition #79388

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Nov 24, 2020

No description provided.

@rustbot rustbot added the A-naked Area: `#[naked]`, prologue and epilogue-free, functions, https://git.io/vAzzS label Nov 24, 2020
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2020
@lcnr
Copy link
Contributor

lcnr commented Nov 24, 2020

lgtm

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 24, 2020

📌 Commit 7a1c52bca8466a8b306a61916b30a13c90699e52 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2020
@tmiasko
Copy link
Contributor Author

tmiasko commented Nov 24, 2020

Removed incorrect use of #[naked] from track-caller test case.

@lcnr
Copy link
Contributor

lcnr commented Nov 24, 2020

👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 24, 2020

📌 Commit 75e00e8 has been approved by lcnr

@bors
Copy link
Contributor

bors commented Nov 25, 2020

⌛ Testing commit 75e00e8 with merge 773ddba...

@bors
Copy link
Contributor

bors commented Nov 25, 2020

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 773ddba to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2020
@bors bors merged commit 773ddba into rust-lang:master Nov 25, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 25, 2020
@tmiasko tmiasko deleted the naked-def-only branch November 25, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-naked Area: `#[naked]`, prologue and epilogue-free, functions, https://git.io/vAzzS merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants