DList update #7944
Closed
DList update #7944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 21, 2013 19:31
This impl was missing for unknown reason.
Make the core Deque implementation a bit simpler by using Option methods when we simply map on a Some value, and deduplicate some common lines.
Factor out internal methods for pop/push ~Node<T>, This allows moving nodes instead of destructuring and allocating new. Make use of this in .merge() so that it requires no allocations when merging two DList.
Add methods to move back element to front or front element to back, without reallocating nodes.
These tests for ~[] performance don't really belong here, they were for comparison.
We don't need TotalOrd for ordered insertion, just the normal sort order Ord.
.peek_next() needs to check the element counter just like the .next() and .next_back() iterators do. Also clarify .insert_next() doc w.r.t double ended iteration.
|
The commit |
|
Otherwise looks good, feel free to r=bblum once you decide how to address my above comment. |
|
I didn't realize DList had turned into an owned data structure with raw back pointers in the time since I wrote it. It's good to see. |
|
I appreciate the comment on naming. At the moment nodes are not exposed at all, so methods taking nodes are not possible. |
bors
added a commit
that referenced
this pull request
Jul 23, 2013
Factor out internal methods to pop/push list nodes so that .merge() and .rotate_to_front(), .rotate_to_back() (new methods) can be implemented without allocating nodes. With that, some cleanup changes to DList use of Option, and adding a missing Encodable implementation.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
…=giraffate Add MSRV to deprecated_cfg_attr changelog: Add MSRV to [`deprecated_cfg_attr`] closes: rust-lang#7922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out internal methods to pop/push list nodes so that .merge() and .rotate_to_front(), .rotate_to_back() (new methods) can be implemented without allocating nodes.
With that, some cleanup changes to DList use of Option, and adding a missing Encodable implementation.