ci: use 20.04 on x86_64-gnu-nopt builder #79536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-testsuite
|
This should be enough! @bors r+ rollup=iffy |
|
📌 Commit 68e15c86aec3fd45f843c785f3669a02f85c7816 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 68e15c86aec3fd45f843c785f3669a02f85c7816 with merge 33f0985b8eeeb8abcaacc6ce9d4120d222a583f8... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Spurious network failure. @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 68e15c86aec3fd45f843c785f3669a02f85c7816 with merge 970455fc2d1d28c7dddc78aa43dedc63939863b3... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
maybe we can @bors retry this once more |
bors
added
S-waiting-on-bors
|
@bors retry |
|
⌛ Testing commit 68e15c86aec3fd45f843c785f3669a02f85c7816 with merge 85a07d14facf9aada1ef48cdbefd85daeafd7e48... |
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
|
@bors retry gha outage |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 68e15c86aec3fd45f843c785f3669a02f85c7816 with merge 37005e4d44e6daf6fcf60c874700b610ca647f60... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
davidtwco
force-pushed
the
focal-fossa-ci
branch
from
68e15c8
to
acf887a
Compare
|
Looks like that last failure wasn't spurious, attempted to address it in most recent push. |
4 tasks
|
@pietroalbini can you re-review? |
This commit switches the x86_64-gnu-nopt builder to use Ubuntu 20.04, which contains a more recent gdb version than Ubuntu 16.04 (newer gdb versions fix a bug that Split DWARF can trigger, see rust-lang#77177 for motivation). x86_64-gnu-nopt is chosen because it runs compare modes, which is how Split DWARF testing is implemented in rust-lang#77177. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
focal-fossa-ci
branch
from
acf887a
to
fb75c32
Compare
|
@bors r+ rollup=never |
|
📌 Commit fb75c32 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the
x86_64-gnu-noptbuilder to use Ubuntu 20.04.Ubuntu 20.04 has a more recent gdb version than Ubuntu 16.04 (9.1 vs 7.11.1), which is required for #77117, as 16.04's gdb 7.11.1 crashes in some cases with Split DWARF.
x86_64-gnu-noptis chosen because it runs compare modes, which is how Split DWARF testing is implemented in #77117.I've not confirmed that the issue is resolved with gdb 9.1 (Feb 2020), but system was using gdb 9.2 (May 2020) and that was fine and it seems more likely to me that the bug was resolved between gdb 7.11.1 (May 2016) and gdb 9.1.
Updating a builder to use 20.04 was suggested by @Mark-Simulacrum in #77117 (comment). I'm not sure if this is the only change that is required - if more are necessary then I'm happy to do that.
r? @pietroalbini
cc @Mark-Simulacrum