small TypeVisitor refactor
#79773
Merged
small TypeVisitor refactor
#79773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
LeSeulArtichaut
approved these changes
Dec 6, 2020
| debug!("check_opaque_for_inheriting_lifetimes: (visit_ty) t={:?}", t); | ||
| if t != self.opaque_identity_ty { | ||
| t.super_visit_with(&mut FindParentLifetimeVisitor(self.generics)) | ||
| .map_break(|FoundParentLifetime| t) |
There was a problem hiding this comment.
I think this in particular is pretty awesome ❤️
Modulo the fact that the visitor names start to look like Java classes now 😆
|
@bors r=oli-obk |
|
📌 Commit e3e4870 has been approved by |
bors
added
S-waiting-on-bors
|
Wow, I had never seen the bors queue that empty 👀 |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @LeSeulArtichaut @scottmcm
adds
ControlFlow::map_break