Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove memoization leftovers from constant evaluation machine #79840

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Remove memoization leftovers from constant evaluation machine #79840

merged 4 commits into from
Dec 17, 2020

Conversation

dvtkrlbs
Copy link
Contributor

@dvtkrlbs dvtkrlbs commented Dec 8, 2020 •
edited
Loading

Closes #79667

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2020
@petrochenkov
Copy link
Contributor

r? @RalfJung

@oli-obk
Copy link
Contributor

oli-obk commented Dec 14, 2020

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 14, 2020

📌 Commit a03feaa has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2020
@bors
Copy link
Contributor

bors commented Dec 14, 2020

⌛ Testing commit a03feaa with merge 494c4050d20b3ddac02d7b8997cfe26c29c937d0...

@bors
Copy link
Contributor

bors commented Dec 14, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 15, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
13c85b3 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
4ee4cf7 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
0a2aeac 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
This was referenced Dec 15, 2020
Closed
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
3039e70 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
ed1f0b5 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#79840 - dvtkrlbs:issue-79667, r=oli-obk
3d8241d 
Remove memoization leftovers from constant evaluation machine

Closes rust-lang#79667
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 16, 2020
Closed
@bors
Copy link
Contributor

bors commented Dec 17, 2020

⌛ Testing commit a03feaa with merge 001bd77...

@bors
Copy link
Contributor

bors commented Dec 17, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 001bd77 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2020
@bors bors merged commit 001bd77 into rust-lang:master Dec 17, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 17, 2020
@dvtkrlbs dvtkrlbs deleted the issue-79667 branch December 17, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk Awaiting requested review from oli-obk

Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

CTFE: remove memoization leftovers
7 participants
@dvtkrlbs @rust-highfive @petrochenkov @oli-obk @bors @RalfJung @rustbot