Rollup of 12 pull requests #79867
Merged
Rollup of 12 pull requests #79867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removing all the indentation before. Co-authored-by: Eric Huss <eric@huss.org>
My understanding is that these API are perma unstable, so it doesn't make sense to pollute docs & IDE completion[1] with them. [1]: rust-lang/rust-analyzer#6738
This fixes occasional proptest failures due to a bug in xsv, which aren't related to bugs in the rust compiler.
Fixes: rust-lang#79725 Some macros can create a situation where `fn_sig_span` and `body_span` map to different files. New documentation on coverage tests incorrectly assumed multiple test binaries could just be listed at the end of the `llvm-cov` command, but it turns out each binary needs a `--object` prefix. This PR fixes the bug and updates the documentation to correct that issue. It also fixes a few other minor issues in internal implementation comments, and adds documentation on getting coverage results for doc tests.
Using an `if` seems like a better semantic fit and saves a few lines.
When encoding a proc-macro crate, there may be gaps in the table (since we only encode the crate root and proc-macro items). Account for this by checking if the entry is present, rather than using `unwrap()`
…ween search result tabs
minor stylistic clippy cleanups simplify if let Some(_) = x to if x.is_some() (clippy::redundant_pattern_matching) don't create owned values for comparison (clippy::cmp_owned) use .contains() or .any() instead of find(x).is_some() (clippy::search_is_some) don't wrap code block in Ok() (clipppy::unit_arg)
…ark-Simulacrum Fix trimming of lint docs Fixes rust-lang#79748. It was removing all the indentation before. r? `@Mark-Simulacrum`
Remove `first_merge` from liveness debug logs
Privatize some of libcore unicode_internals My understanding is that these API are perma unstable, so it doesn't make sense to pollute docs & IDE completion[1] with them. [1]: rust-lang/rust-analyzer#6738
Update xsv to prevent random CI failures This fixes occasional proptest failures due to a bug in xsv, which aren't related to bugs in the rust compiler. See rust-lang#79751 (comment) for context.
…=lcnr Account for gaps in def path table during decoding When encoding a proc-macro crate, there may be gaps in the table (since we only encode the crate root and proc-macro items). Account for this by checking if the entry is present, rather than using `unwrap()`
…1.0, r=tmandry Fixes to Rust coverage Fixes: rust-lang#79725 Some macros can create a situation where `fn_sig_span` and `body_span` map to different files. New documentation on coverage tests incorrectly assumed multiple test binaries could just be listed at the end of the `llvm-cov` command, but it turns out each binary needs a `--object` prefix. This PR fixes the bug and updates the documentation to correct that issue. It also fixes a few other minor issues in internal implementation comments, and adds documentation on getting coverage results for doc tests.
Strip prefix instead of replacing it with empty string r? `@lcnr,` since you reviewed my other PR in the area. `@rustbot` modify labels +C-cleanup +T-compiler
Simplify visit_{foreign,trait}_item
Using an `if` seems like a better semantic fit and saves a few lines.
Noticed while looking at rust-lang#79752, but that's already merged.
r? `@lcnr,` cc `@cjgillot`
`@rustbot` modify labels +C-cleanup +T-compiler
Move RWUTable to a separate module
Update LLVM submodule * [[msan] Fix bugs when instrumenting x86.avx512*_cvt* intrinsics](rust-lang/llvm-project#84) * [[X86][AVX512] Only lower to VPALIGNR if we have BWI (PR48322)](rust-lang/llvm-project#85)
Remove tab-lock and replace it with ctrl+up/down arrows to switch between search result tabs Fixes rust-lang#65212 What took the longest time was to update the help popup in the end. r? `@Manishearth`
|
@bors r+ rollup=never p=5 |
|
📌 Commit f74f3b2 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
first_mergefrom liveness debug logs #79777 (Removefirst_mergefrom liveness debug logs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup