-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-level docs to rustc_middle::ty #80225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 20, 2020
r? @lcnr |
Thanks 👍 I think that stuff like this can be really helpful to newcomers @bors r+ rollup |
📌 Commit 9f8c8e4 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 20, 2020
@lcnr Great to hear! Thank you. 🙏 |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 21, 2020
Add module-level docs to rustc_middle::ty I thought it would be nice to point out `Ty` and `TyCtxt` on the module page, and link out to the [rustc-dev-guide chapter](https://rustc-dev-guide.rust-lang.org/ty.html).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2020
…laumeGomez Rollup of 17 pull requests Successful merges: - rust-lang#80136 (Add test for issue rust-lang#74824) - rust-lang#80203 (Edit rustc_middle::lint::LintSource docs) - rust-lang#80204 (docs: Edit rustc_middle::ty::query::on_disk_cache) - rust-lang#80219 (Fix labels for 'Library Tracking Issue' template) - rust-lang#80222 (Fix rustc-std-workspace-core documentation) - rust-lang#80223 (docs: Fix outdated crate reference) - rust-lang#80225 (Add module-level docs to rustc_middle::ty) - rust-lang#80241 (Fix typo) - rust-lang#80248 (Remove `I-prioritize` from Zulip topic) - rust-lang#80266 (Remove redundant test) - rust-lang#80272 (rustc_span: Provide a reserved identifier check for a specific edition) - rust-lang#80285 (Update books) - rust-lang#80286 (docs: Edit rustc_middle::middle::privacy) - rust-lang#80297 (Add some intra-doc links to compiler docs) - rust-lang#80298 (Improve the code quality by using matches macro) - rust-lang#80299 (Turn helper method into a closure) - rust-lang#80302 (docs: Update rustc_middle::middle::region::ScopeTree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nice to point out
Ty
andTyCtxt
on the module page, and link out to the rustc-dev-guide chapter.