Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unnecessarily override attrs for Module #80340

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 23, 2020

They were never changed from the default, which you can get with tcx.get_attrs().

They were never changed from the default, which you can get with
`tcx.get_attrs()`.
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 23, 2020
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2020
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 24, 2020

📌 Commit 6dc4f7a has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#79213 (Stabilize `core::slice::fill`)
 - rust-lang#79999 (Refactored verbose print into a function)
 - rust-lang#80160 (Implemented a compiler diagnostic for move async mistake)
 - rust-lang#80274 (Rename rustc_middle::lint::LintSource)
 - rust-lang#80280 (Add installation commands to `x` tool README)
 - rust-lang#80319 (Fix elided lifetimes shown as `'_` on async functions)
 - rust-lang#80327 (Updated the match with the matches macro)
 - rust-lang#80330 (Fix typo in simplify_try.rs)
 - rust-lang#80340 (Don't unnecessarily override attrs for Module)
 - rust-lang#80342 (Fix typo)
 - rust-lang#80352 (BTreeMap: make test cases more explicit on failure)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 28267e3 into rust-lang:master Dec 25, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 25, 2020
@jyn514 jyn514 deleted the less-modules-attrs branch December 25, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants