Make forget intrinsic safe #80477
Merged
Make forget intrinsic safe #80477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
dtolnay
reviewed
Dec 29, 2020
Comment on lines
155
to
156
| // SAFETY: the forget intrinsic could be safe, but there's no point in making it safe since | ||
| // we'll be implementing this function soon via `ManuallyDrop` |
There was a problem hiding this comment.
Reassigning to @oli-obk, the person who authored the "there's no point in making it safe" comment.
|
r? @oli-obk |
|
🤷 I just considered the effort of doing a PR not worth it, but now that it's done, let's not let it go to waste @bors r+ rollup |
|
📌 Commit 5718cc2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 30, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#79812 (Lint on redundant trailing semicolon after item) - rust-lang#80348 (remove redundant clones (clippy::redundant_clone)) - rust-lang#80358 (Edit rustc_span documentation) - rust-lang#80457 (Add missing commas to `rustc_ast_pretty::pp` docs) - rust-lang#80461 (Add llvm-libunwind change to bootstrap CHANGELOG) - rust-lang#80464 (Use Option::map_or instead of open coding it) - rust-lang#80465 (Fix typo in ffi-pure.md) - rust-lang#80467 (More uses of the matches! macro) - rust-lang#80469 (Fix small typo in time comment) - rust-lang#80472 (Use sans-serif font for the "all items" page links) - rust-lang#80477 (Make forget intrinsic safe) - rust-lang#80482 (don't clone copy types) - rust-lang#80487 (don't redundantly repeat field names) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.