Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rollup merge of #80637 - LingMan:filter, r=oli-obk" #80728

Closed
wants to merge 1 commit into from

Conversation

rylev
Copy link
Member

@rylev rylev commented Jan 5, 2021

Reverts #80637 to test for possible performance regressions.

In the latest perf triage, the rollup that the reverted PR was a part of featured a performance regression. We are testing whether the reverted PR was indeed (at least partially) responsible.

This reverts commit faf8bed, reversing
changes made to 1c6593c.

r? @ghost

cc @LingMan @oli-obk

@rylev
Copy link
Member Author

rylev commented Jan 5, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 5, 2021

⌛ Trying commit f1150ba with merge 875ad6e79a63f1e23b2e3fb22b22441e0a0b8384...

@bors
Copy link
Contributor

bors commented Jan 5, 2021

☀️ Try build successful - checks-actions
Build commit: 875ad6e79a63f1e23b2e3fb22b22441e0a0b8384 (875ad6e79a63f1e23b2e3fb22b22441e0a0b8384)

@rust-timer
Copy link
Collaborator

Queued 875ad6e79a63f1e23b2e3fb22b22441e0a0b8384 with parent 68ec332, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 5, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (875ad6e79a63f1e23b2e3fb22b22441e0a0b8384): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 5, 2021
@rylev
Copy link
Member Author

rylev commented Jan 7, 2021

This change did not affect performance. Closing.

@rylev rylev closed this Jan 7, 2021
@rylev rylev deleted the revert-80637 branch January 7, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants