Rollup of 11 pull requests #80781
Closed
Rollup of 11 pull requests #80781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hope later to extend `core::str::Pattern` to slices too, perhaps as part of stabilising that. We want to minimise the amount of type inference breakage when we do that, so we don't want to stabilise strip_prefix and strip_suffix taking a simple `&[T]`. @KodrAus suggested the approach of introducing a new perma-unstable trait, which reduces this future inference break risk. I found it necessary to make two impls of this trait, as the unsize coercion don't apply when hunting for trait implementations. Since SlicePattern's only method returns a reference, and the whole trait is just a wrapper for slices, I made the trait type be the non-reference type [T] or [T;N] rather than the reference. Otherwise the trait would have a lifetime parameter. I marked both the no-op conversion functions `#[inline]`. I'm not sure if that is necessary but it seemed at the very least harmless. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Co-authored-by: Ashley Mannix <kodraus@hey.com>
Co-authored-by: David Tolnay <dtolnay@gmail.com>
This trait is ?Sized and is often slices. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Fix some punctuation and wording, and add intra-documentation links.
This fixes a mobile UI bug where a vertical scrollbar would always be rendered on the sidebar nav when the menu was closed.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
make the generic function pattern more specific and remove the extra $ that failes the matching
Stabilize slice::strip_prefix and slice::strip_suffix These two methods are useful. The corresponding methods on `str` are already stable. I believe that stablising these now would not get in the way of, in the future, extending these to take a richer pattern API a la `str`'s patterns. Tracking PR: rust-lang#73413. I also have an outstanding PR to improve the docs for these two functions and the corresponding ones on `str`: rust-lang#75078 I have tried to follow the [instructions in the dev guide](https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr). The part to do with `compiler/rustc_feature` did not seem applicable. I assume that's because these are just library features, so there is no corresponding machinery in rustc.
…ntifier-E0435, r=petrochenkov Add pointing const identifier when emitting E0435 Fix rust-lang#79919
Edit rustc_ast::tokenstream docs Fix some punctuation and wording, and add intra-documentation links.
Properly handle primitive disambiguators in rustdoc Fixes rust-lang#80559 r? `@jyn514` Is there a way to test that the generated intra-doc link is what I expect?
…nkov Limit target endian to an enum instead of free string This is rust-lang#77604 revived.
Remove bottom margin from crate version when the docs sidebar is collapsed This fixes a mobile UI bug where a vertical scrollbar would always be rendered on the sidebar nav when the menu was closed. When opened, the overflow would be handled by the opened sidebar, causing the scrollbar to disappear, and the contents to shift to the right. ## Firefox **Before**   **After**   ## Chrome **Before**  **After** 
rustdoc: Turn `next_def_id` comments into docs Split out from rust-lang#80740. r? `@jyn514`
Update cargo 12 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..329895f5b52a358e5d9ecb26215708b5cb31d906 2020-12-22 18:10:56 +0000 to 2021-01-06 00:01:52 +0000 - metadata: Supply local path for path dependencies (rust-lang/cargo#8994) - Add support for Rust edition 2021. (rust-lang/cargo#8922) - Stabilize -Zfeatures and -Zpackage-features. (rust-lang/cargo#8997) - Small refactor, adding a list of all kinds to BuildContext (rust-lang/cargo#9046) - Fix git http.proxy config setting. (rust-lang/cargo#8986) - Clarify the help text of `--aggressive` and `--precise` of `update` (rust-lang/cargo#9031) - Assert that tests are run in the crate directory (rust-lang/cargo#9037) - Update mdbook (rust-lang/cargo#9044) - Bump to 0.52.0, update changelog (rust-lang/cargo#9042) - Fix redundant semicolon. (rust-lang/cargo#9033) - Clarify fingerprint log messages (rust-lang/cargo#9026) - Update credential docs for gnome-secret. (rust-lang/cargo#9013)
…=lzutao Don't use to_string on Symbol in rustc_passes/check_attr.rs Improve code from rust-lang#80686. r? `@lzutao`
…wiser handle generic trait methods in coverage-report tests also make the generic function pattern more specific and remove the extra $ that fails the matching. r? `@wesleywiser` as this was failing the test of rust-lang#76896
Return EOF_CHAR constant instead of magic char.
|
@bors r+ rollup=never p=5 |
|
📌 Commit e4ecfea has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e4ecfea with merge e242cf55bf9a34007e426fb67e50d0c2b745fdd6... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Failed by #80761, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
next_def_idcomments into docs #80744 (rustdoc: Turnnext_def_idcomments into docs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup