-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #80790
Merged
Merged
Rollup of 10 pull requests #80790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some punctuation and wording, and add intra-documentation links.
Fixes: rust-lang#80060 Also adds additional test cases for coverage of doctests.
This fixes a mobile UI bug where a vertical scrollbar would always be rendered on the sidebar nav when the menu was closed.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Change: ``` `parse` can parse any type that... ``` to: ``` `parse` can parse into any type that... ``` Word `into` added to be more precise and in coherence with other parts of the doc.
…ntifier-E0435, r=petrochenkov Add pointing const identifier when emitting E0435 Fix rust-lang#79919
…4.0, r=wesleywiser MIR Inline is incompatible with coverage Fixes: rust-lang#80060 Fixed by disabling inlining if `-Zinstrument-coverage` is set. The PR also adds additional use cases to the coverage test for doctests. r? `@wesleywiser` cc: `@tmandry`
Edit rustc_ast::tokenstream docs Fix some punctuation and wording, and add intra-documentation links.
Properly handle primitive disambiguators in rustdoc Fixes rust-lang#80559 r? ``@jyn514`` Is there a way to test that the generated intra-doc link is what I expect?
Remove bottom margin from crate version when the docs sidebar is collapsed This fixes a mobile UI bug where a vertical scrollbar would always be rendered on the sidebar nav when the menu was closed. When opened, the overflow would be handled by the opened sidebar, causing the scrollbar to disappear, and the contents to shift to the right. ## Firefox **Before** ![before-ff](https://user-images.githubusercontent.com/139487/103713599-c2f74c00-4f8a-11eb-88c0-d5c6c088f8a0.png) ![before](https://user-images.githubusercontent.com/139487/103713793-2bdec400-4f8b-11eb-8223-94b77cc05f71.gif) **After** ![after-ff](https://user-images.githubusercontent.com/139487/103713605-c8ed2d00-4f8a-11eb-9ee8-f86cafaa8775.png) ![after](https://user-images.githubusercontent.com/139487/103713805-31d4a500-4f8b-11eb-9e5b-4156402ca43e.gif) ## Chrome **Before** ![localhost_8000_unicode_xid_ (1)](https://user-images.githubusercontent.com/139487/103713626-d60a1c00-4f8a-11eb-8605-cc98e04e9ad0.png) **After** ![localhost_8000_unicode_xid_](https://user-images.githubusercontent.com/139487/103713622-d1456800-4f8a-11eb-8c66-7d19f81614ca.png)
rustdoc: Turn `next_def_id` comments into docs Split out from rust-lang#80740. r? ``@jyn514``
…=lzutao Don't use to_string on Symbol in rustc_passes/check_attr.rs Improve code from rust-lang#80686. r? ``@lzutao``
Improve wording of parse doc Change: ``` `parse` can parse any type that... ``` to: ``` `parse` can parse into any type that... ``` Word `into` added to be more precise and in coherence with other parts of the doc.
Return EOF_CHAR constant instead of magic char.
rustc_parse: Better spans for synthesized token streams I think using the nonterminal span for synthesizing its tokens is a better approximation than using `DUMMY_SP` or the attribute span like rust-lang#79472 did in `expand.rs`. r? `@Aaron1011`
@bors r+ rollup=never p=10 |
📌 Commit 695f878 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 7, 2021
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
This was referenced Jan 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
next_def_id
comments into docs #80744 (rustdoc: Turnnext_def_id
comments into docs)Failed merges:
PrintState::insert_extra_parens
#80785 (rustc_ast_pretty: RemovePrintState::insert_extra_parens
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup